From owner-cvs-all Tue Sep 21 23:50:58 1999 Delivered-To: cvs-all@freebsd.org Received: from gratis.grondar.za (gratis.grondar.za [196.7.18.133]) by hub.freebsd.org (Postfix) with ESMTP id 3031314E56; Tue, 21 Sep 1999 23:50:49 -0700 (PDT) (envelope-from mark@grondar.za) Received: from grondar.za (localhost [127.0.0.1]) by gratis.grondar.za (8.9.3/8.9.3) with ESMTP id IAA77877; Wed, 22 Sep 1999 08:50:39 +0200 (SAST) (envelope-from mark@grondar.za) Message-Id: <199909220650.IAA77877@gratis.grondar.za> To: Dmitrij Tejblum Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/secure/lib/libcrypt Makefile src/lib/libcrypt Makefile Date: Wed, 22 Sep 1999 08:50:38 +0200 From: Mark Murray Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk > You know, you could DTRT from the beginning. You could do not do the > major version bump secretly. You could do not blame other people when > you do a mistake. You could have your commit reviewed by > someone else, even though you are the MAINTAINER. That reviewer could > tell you that your changes in libscrypt break most programs that create > new password, including the adduser script. The programs use a random > string as the salt, and don't prefix the salt with "$1$" or similar. > (Not only this is the traditional usage, it is even documented in > SUSV2). Here is a trivial patch, feel free to review and commit it > (I even tested it somehow :-). I'm having a problem understanding the above. > Index: crypt.c > =================================================================== > RCS file: /home/ncvs/src/lib/libcrypt/crypt.c,v > retrieving revision 1.12 > diff -u -r1.12 crypt.c > --- crypt.c 1999/09/20 12:45:49 1.12 > +++ crypt.c 1999/09/21 21:25:55 > @@ -44,6 +44,6 @@ > #ifdef NONEXPORTABLE_CRYPT > return crypt_des(passwd, salt); > #else > - return NULL; > + return crypt_md5(passwd, salt); > #endif > } ...but this looks sane. OK, I'll commit it. M -- Mark Murray Join the anti-SPAM movement: http://www.cauce.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message