Date: Thu, 6 May 1999 15:14:56 -0500 From: "Richard Seaman, Jr." <dick@tar.com> To: grog@freebsd.org Subject: Buglet in SiS support in ide_pci.c Message-ID: <19990506151456.A454@tar.com>
next in thread | raw e-mail | index | archive | help
--tKW2IUtsqtDRztdT
Content-Type: text/plain; charset=us-ascii
I was just installing a new drive on the machine with the
SiS 5591 chipset, and noticed strange results on the
verbose status probes.
It appears to me that the UDMA status register reported
somehow got flipped. It appears to only affect the
status report in verbose mode, and not the actual setting
of the controller.
If you would like me to commit this fix, let me know.
--
Richard Seaman, Jr. email: dick@tar.com
5182 N. Maple Lane phone: 414-367-5450
Chenequa WI 53058 fax: 414-367-5852
--tKW2IUtsqtDRztdT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="ide_pci.c.diff"
Index: sys/pci/ide_pci.c
===================================================================
RCS file: /home/ncvs/src/sys/pci/ide_pci.c,v
retrieving revision 1.33
diff -u -r1.33 ide_pci.c
--- ide_pci.c 1999/04/24 20:13:58 1.33
+++ ide_pci.c 1999/05/06 18:36:30
@@ -1161,8 +1161,8 @@
printf ("SiS 5591 status: %s drive %d Ultra DMA %s",
unitno < 2 ? "primary" : "secondary",
unitno & 1,
- (DATC & 0x80) ? "disabled\n" : "enabled");
- if ((DATC & 0x80) == 0)
+ (DATC & 0x80) ? "enabled" : "disabled\n");
+ if (DATC & 0x80)
printf (", %d PCICLK data out\n", ((DATC >> 5) & 0x3) + 1);
printf ("SiS 5591 status: %s drive %d postwrite %s, prefetch %s prefetch count is %d\n",
unitno < 2 ? "primary" : "secondary",
--tKW2IUtsqtDRztdT--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990506151456.A454>