Date: Tue, 28 Mar 2006 20:40:22 GMT From: John Baldwin <jhb@freebsd.org> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/94939: [acpi] [patch] reboot(8) fails on IBM / Intel blades Message-ID: <200603282040.k2SKeMJd017784@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/94939; it has been noted by GNATS. From: John Baldwin <jhb@freebsd.org> To: "Devon H. O'Dell" <devon.odell@gmail.com> Cc: "Nate Lawson" <nate@root.org>, bug-followup@freebsd.org Subject: Re: kern/94939: [acpi] [patch] reboot(8) fails on IBM / Intel blades Date: Tue, 28 Mar 2006 15:40:36 -0500 On Tuesday 28 March 2006 15:21, Devon H. O'Dell wrote: > > The patch has some other major problems that should be addressed before > > committing. It should not manually be parsing the GAS and mapping > > memory etc. Instead, it should just use AcpiHwLowLevelWrite(): > > > > ACPI_STATUS > > AcpiHwLowLevelWrite ( > > UINT32 Width, > > UINT32 Value, > > ACPI_GENERIC_ADDRESS *Reg); > > > > Width should be 8, value should be the reset value in the FADT, and Reg > > should be the FADT GAS struct. > > Please see http://www.sitetronics.com/~dodell/acpi2.diff (also > attached). This addresses this issue and significantly reduces the > size of the diff :) > > --Devon Maybe it should use AcpiGbl_FADT->ResetRegister.RegisterBitWidth rather than hardcoding 8? -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200603282040.k2SKeMJd017784>