From owner-svn-src-head@freebsd.org Thu Nov 16 04:41:15 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E965EDBC57A; Thu, 16 Nov 2017 04:41:15 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f43.google.com (mail-it0-f43.google.com [209.85.214.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 812176BD38; Thu, 16 Nov 2017 04:41:15 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f43.google.com with SMTP id l196so4396227itl.4; Wed, 15 Nov 2017 20:41:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=ZRDiJ2M+I8PPqaSWpvUnsEtOi+A13Vw7pvSou6zWd0k=; b=iTOaaynmXzmdhwIPDMGOUa72eQ9CkSdfMk9QB/3l/v4/9IIcc1oj+nSkiZTrWwtQna Bc2z8dfGnBn00QvEVifyDNfCSwugb398+aUIe10m11Yw5VR6KXYibq3MPkIGD4VE6vnv TJdB0ITFT9vong/Vrh/704mEIniGxsiN8pV9RLBG4gaIotbl+qbGW7Kg5aPKoMh/Cmau PkhCK+UMGg1VOxy+gWoj2kGtjnxVtulJVlGkK1MNXtzWYnHf28keRbxcFa+fAOqF9wz+ mw8ut0hMstvmeUyziPwF102GbNrqe0T+yLFROG+YI+xT5XfQ950lCMIEdWYKzpzKQJHu 1icg== X-Gm-Message-State: AJaThX7mkIc4LQRpmmmi5/OQTovKRTGMEQpkeWHatlZ6zykzCTnR1uUe +RCILTpZaMo5xzVjf311Vt7/nW67 X-Google-Smtp-Source: AGs4zMZMX72Rlg/b1Vz4/E0Dm4aoWJpMdK6L5vgWwTmSsY7iCQYWkGVoJrjogegvIxfwU/GlBg0U4g== X-Received: by 10.36.65.91 with SMTP id x88mr821372ita.82.1510803494635; Wed, 15 Nov 2017 19:38:14 -0800 (PST) Received: from mail-it0-f50.google.com (mail-it0-f50.google.com. [209.85.214.50]) by smtp.gmail.com with ESMTPSA id u188sm276053itb.2.2017.11.15.19.38.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Nov 2017 19:38:14 -0800 (PST) Received: by mail-it0-f50.google.com with SMTP id f187so4328086itb.1; Wed, 15 Nov 2017 19:38:14 -0800 (PST) X-Received: by 10.36.192.2 with SMTP id u2mr741567itf.119.1510803494229; Wed, 15 Nov 2017 19:38:14 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.2.165.150 with HTTP; Wed, 15 Nov 2017 19:38:13 -0800 (PST) In-Reply-To: <201704152015.v3FKFiwZ006836@repo.freebsd.org> References: <201704152015.v3FKFiwZ006836@repo.freebsd.org> From: Conrad Meyer Date: Wed, 15 Nov 2017 19:38:13 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r316980 - head/contrib/zstd/programs To: Baptiste Daroussin Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org, Allan Jude Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2017 04:41:16 -0000 Please revert this change. First, it introduces the POLA-violating behavior that zstdcat deletes its source files. This is not how zcat/bzcat behaves. Second, it introduces a needless behavioral difference between FreeBSD zstd and the rest of the world's zstd. The zstd documentation we ship continues to claim that zstd preserves source files by default, yet this change makes that documentation exactly backwards. While we can change FreeBSD's documentation to accommodate the change, we can't change Google results. Thanks, Conrad On Sat, Apr 15, 2017 at 1:15 PM, Baptiste Daroussin wrote: > Author: bapt > Date: Sat Apr 15 20:15:44 2017 > New Revision: 316980 > URL: https://svnweb.freebsd.org/changeset/base/316980 > > Log: > Change some default to make zstd a dropin replacement for gzip,bzip etc > in most cases > > Changes ares: > - quiet by default > - remove the source files one compression completion by default > > Modified: > head/contrib/zstd/programs/fileio.c > head/contrib/zstd/programs/zstdcli.c > > Modified: head/contrib/zstd/programs/fileio.c > ============================================================================== > --- head/contrib/zstd/programs/fileio.c Sat Apr 15 20:06:24 2017 (r316979) > +++ head/contrib/zstd/programs/fileio.c Sat Apr 15 20:15:44 2017 (r316980) > @@ -138,7 +138,7 @@ static U32 g_dictIDFlag = 1; > void FIO_setDictIDFlag(unsigned dictIDFlag) { g_dictIDFlag = dictIDFlag; } > static U32 g_checksumFlag = 1; > void FIO_setChecksumFlag(unsigned checksumFlag) { g_checksumFlag = checksumFlag; } > -static U32 g_removeSrcFile = 0; > +static U32 g_removeSrcFile = 1; > void FIO_setRemoveSrcFile(unsigned flag) { g_removeSrcFile = (flag>0); } > static U32 g_memLimit = 0; > void FIO_setMemLimit(unsigned memLimit) { g_memLimit = memLimit; } > > Modified: head/contrib/zstd/programs/zstdcli.c > ============================================================================== > --- head/contrib/zstd/programs/zstdcli.c Sat Apr 15 20:06:24 2017 (r316979) > +++ head/contrib/zstd/programs/zstdcli.c Sat Apr 15 20:15:44 2017 (r316980) > @@ -61,7 +61,7 @@ > #define MB *(1 <<20) > #define GB *(1U<<30) > > -#define DEFAULT_DISPLAY_LEVEL 2 > +#define DEFAULT_DISPLAY_LEVEL 1 > > static const char* g_defaultDictName = "dictionary"; > static const unsigned g_defaultMaxDictSize = 110 KB; >