Date: Fri, 31 May 2002 22:12:52 -0700 From: "Bruce A. Mah" <bmah@freebsd.org> To: Makoto Matsushita <matusita@jp.FreeBSD.org> Cc: current@freebsd.org Subject: Re: Call for Review: allow sysinstall to tweak tri-value sendmail_enable Message-ID: <200206010512.g515CqQI021309@intruder.bmah.org> In-Reply-To: <20020601130758S.matusita@jp.FreeBSD.org> References: <20020601130758S.matusita@jp.FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
If memory serves me right, Makoto Matsushita wrote:
> Following patch creates submenu to change the sendmail_enable value.
> However, I don't know who want to set this variable to 'NO'. If
> selecting 'YES' and 'NONE' is enough, I'll try to make another patch.
>
> Any comments? I want to push this feature to 4.6-RELEASE...
Comments on the text only (i.e. I haven't tested the new menus)...
Bruce.
> Index: menus.c
> ===================================================================
> RCS file: /home/ncvs/src/usr.sbin/sysinstall/menus.c,v
> retrieving revision 1.343
> diff -u -r1.343 menus.c
> --- menus.c 20 May 2002 17:08:00 -0000 1.343
> +++ menus.c 31 May 2002 17:49:18 -0000
> @@ -1372,11 +1372,31 @@
> { " Rwhod", "This machine wants to run the rwho daemon",
> dmenuVarCheck, dmenuToggleVariable, NULL, "rwhod_enable=YES" },
> { " Sendmail", "This machine wants to run the sendmail daemon",
> - dmenuVarCheck, dmenuToggleVariable, NULL, "sendmail_enable=YES" },
> + NULL, dmenuSubmenu, NULL, &MenuSendmail },
> { " Sshd", "This machine wants to run the ssh daemon",
> dmenuVarCheck, dmenuToggleVariable, NULL, "sshd_enable=YES" },
> { " TCP Extensions", "Allow RFC1323 and RFC1644 TCP extensions?",
> dmenuVarCheck, dmenuToggleVariable, NULL, "tcp_extensions=YES" },
> + { NULL } },
> +};
> +
> +DMenu MenuSendmail = {
> + DMENU_NORMAL_TYPE | DMENU_SELECTION_RETURNS,
> + "Sendmail Invocation Selection",
> + "There are three options for invocating sendmail at startup.\n"
s/invocating/invoking/
> + "Please select Yes if you want to use sendmail as your mail transfer\n"
> + "agent. Selecting No disables sendmail to open network socket for\n"
s/sendmail to open/sendmail's/
> + "incoming email, but still runs at startup. None disables sendmail\n"
s/still runs at startup/still enables sendmail for outbound mail/
You will probably need to word-wrap differently after this change.
> + "completely at startup.",
> + NULL,
> + NULL,
> + {
> + { " Yes", "Start sendmail",
> + dmenuVarCheck, dmenuSetVariable, NULL, "sendmail_enable=YES" },
> + { " No", "Start sendmail, but don't listen from network"
> ,
> + dmenuVarCheck, dmenuSetVariable, NULL, "sendmail_enable=NO" },
> + { " None", "Don't start any sendmail processes",
> + dmenuVarCheck, dmenuSetVariable, NULL, "sendmail_enable=NONE" },
> { NULL } },
> };
>
> Index: sysinstall.h
> ===================================================================
> RCS file: /home/ncvs/src/usr.sbin/sysinstall/sysinstall.h,v
> retrieving revision 1.227
> diff -u -r1.227 sysinstall.h
> --- sysinstall.h 31 May 2002 13:38:17 -0000 1.227
> +++ sysinstall.h 31 May 2002 17:49:19 -0000
> @@ -407,6 +407,7 @@
> extern DMenu MenuSysconsScrnmap; /* System console screenmap con
> figuration menu */
> extern DMenu MenuSysconsTtys; /* System console terminal t
> ype menu */
> extern DMenu MenuNetworking; /* Network configuration menu
> */
> +extern DMenu MenuSendmail; /* Sendmail configuration menu
> */
> extern DMenu MenuInstallCustom; /* Custom Installation menu
> */
> extern DMenu MenuDistributions; /* Distribution menu
> */
> extern DMenu MenuDiskDevices; /* Disk type devices
> */
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-current" in the body of the message
>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200206010512.g515CqQI021309>