From owner-freebsd-ports@FreeBSD.ORG Wed May 17 21:06:47 2006 Return-Path: X-Original-To: freebsd-ports@freebsd.org Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 077DD16A57E for ; Wed, 17 May 2006 21:06:47 +0000 (UTC) (envelope-from beech@alaskaparadise.com) Received: from pinnacle.akherb.com (60-105-237-24.gci.net [24.237.105.60]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9BC1843D45 for ; Wed, 17 May 2006 21:06:46 +0000 (GMT) (envelope-from beech@alaskaparadise.com) Received: by pinnacle.akherb.com (Postfix, from userid 1007) id 1A0BF5D20; Wed, 17 May 2006 13:06:46 -0800 (AKDT) X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pinnacle.akherb.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=4.0 tests=AWL,BAYES_00 autolearn=ham version=3.1.1 Received: from [192.168.241.103] (7-137-58-66.gci.net [66.58.137.7]) by pinnacle.akherb.com (Postfix) with ESMTP id 0F20B5C0B for ; Wed, 17 May 2006 13:06:45 -0800 (AKDT) From: Beech Rintoul Organization: Alaska Paradise To: freebsd-ports@freebsd.org Date: Wed, 17 May 2006 13:06:30 -0800 User-Agent: KMail/1.9.1 MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1452417.8bYFHeCHNK"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200605171306.42686.beech@alaskaparadise.com> Subject: Help with makefile options X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 May 2006 21:07:29 -0000 --nextPart1452417.8bYFHeCHNK Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline I submitted an update and the comitter didn't like the way options were=20 defined. He said: > =A0On Wednesday 17 May 2006 03:56, you wrote: > =A0> Could you please check the way you use OPTIONS against the respective > =A0> PH chapter ? (check "on" options against WITHOUT and "off" against W= ITH) > =A0> (I don't think you actually break something because the "bug" mentio= ned > =A0> there only affects make depend /describe, but let's be consistent). "Due to a deficiency in the infrastructure, you can only test WITH_* variables for options, which are OFF by default, and WITHOUT_* variables for options, which defaults to ON" And an example: OPTIONS=3D =A0 =A0 =A0 =A0IPV6 "Use IPv6" off \ =2Eif defined(WITH_IPV6) =2Eif defined(WITHOUT_IPV6) second .if should be: ,if !defined(WITH_IPV6) =A0> grep IFSESSION Makefile =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 IFSESSION "Include mod_ifsession" on \ =2Eif defined(WITH_IFSESSION) should be .if !defined(WITHOUT_IFSESSION) How would this work? It looks to me like they would be defined as opposite = of=20 what they are intended to do. Could someone explain this to me? I seem to b= e=20 missing something. Beech =2D-=20 =2D------------------------------------------------------------------------= =2D------------- Beech Rintoul - Sys. Administrator - beech@alaskaparadise.com /"\ ASCII Ribbon Campaign | Alaska Paradise \ / - NO HTML/RTF in e-mail | 201 East 9Th Avenue Ste.310 X - NO Word docs in e-mail | Anchorage, AK 99501 / \ - Please visit Alaska Paradise - http://www.alaskaparadise.com =2D------------------------------------------------------------------------= =2D------------- --nextPart1452417.8bYFHeCHNK Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQBEa5Bip5D0B1NlT4URAo7fAJ9jgMWiHdkdnjTcGFkYhPjMxpIQ7wCfZSww bB3Wl9Z+lmOWDbTKI10DBT8= =Hfl+ -----END PGP SIGNATURE----- --nextPart1452417.8bYFHeCHNK--