From owner-cvs-all  Sun Feb 18 19:17:37 2001
Delivered-To: cvs-all@freebsd.org
Received: from fw.wintelcom.net (ns1.wintelcom.net [209.1.153.20])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2E06037B65D; Sun, 18 Feb 2001 19:17:25 -0800 (PST)
Received: (from bright@localhost)
	by fw.wintelcom.net (8.10.0/8.10.0) id f1J3HO925507;
	Sun, 18 Feb 2001 19:17:24 -0800 (PST)
Date: Sun, 18 Feb 2001 19:17:24 -0800
From: Alfred Perlstein <bright@wintelcom.net>
To: Matt Dillon <dillon@earth.backplane.com>
Cc: Darren Reed <darrenr@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/netinet fil.c ip_auth.c ip_auth.h ip_compat.h ip_fil.c ip_fil.h ip_frag.c ip_frag.h ip_ftp_pxy.c ip_log.c ip_nat.c ip_nat.h ip_proxy.h ip_raudio_pxy.c ip_rcmd_pxy.c ip_state.c ip_state.h ipl.h mlfk_ipl.c
Message-ID: <20010218191724.H6641@fw.wintelcom.net>
References: <200102172042.f1HKg9A20215@freefall.freebsd.org> <200102190119.f1J1J8P32906@earth.backplane.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <200102190119.f1J1J8P32906@earth.backplane.com>; from dillon@earth.backplane.com on Sun, Feb 18, 2001 at 05:19:08PM -0800
X-all-your-base: are belong to us.
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

> :darrenr     2001/02/17 12:42:09 PST
> :
> :  Modified files:        (Branch: RELENG_4)
> :    sys/netinet          fil.c ip_auth.c ip_auth.h ip_compat.h 
> :                         ip_fil.c ip_fil.h ip_frag.c ip_frag.h 
> :                         ip_ftp_pxy.c ip_log.c ip_nat.c ip_nat.h 
> :                         ip_proxy.h ip_raudio_pxy.c ip_rcmd_pxy.c 
> :                         ip_state.c ip_state.h ipl.h mlfk_ipl.c 
> :  Log:
> :  merge changes from 3.4.8 to 3.4.16

* Matt Dillon <dillon@earth.backplane.com> [010218 17:19] wrote:
>     What in god's name is this?  
> 
>     This one MFC appears to cover commits made to current going all the
>     way back to October 2000, all in one go.  Darren, did you actually
>     test this stuff in aggregate under -stable significantly before MFCing it?
> 
>     Also, these changes should be MFC'd piecemeal, not all at once, and
>     the commit message is completely opaque.  There appear to be all sorts
>     of things mixed in here... nat changes, ipv6 changes, base ip and tcp
>     protocol changes, etc.  
> 
>     -stable is what people have in production.  I really, really, really do
>     not think this sort of everything-under-the-sun commit is prudent.  I
>     can see doing an aggregate commit for IPV6 conditionalized things, since
>     it's still experimental in -stable, but not everything else.

This is contrib software, he's entitiled to the same sort of
guidelines as sendmail, gcc, bind, etc.  He doesn't develop ipfilter
_for_ FreeBSD, he mearly does the import management for his program
as if he was the "ipfilter" guru (because he is).

If there's any sort of problem because of this it will look bad
for ipfilter, not FreeBSD.  Also, if you don't like or trust his
commit style, then there's always ipfw. :)

-- 
-Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org]
"I have the heart of a child; I keep it in a jar on my desk."


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message