From owner-svn-ports-all@freebsd.org Tue Aug 29 22:12:38 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9F0CCDE6F7A; Tue, 29 Aug 2017 22:12:38 +0000 (UTC) (envelope-from jmd@freebsd.org) Received: from www.poelloepaeae.de (v22017034403546374.happysrv.de [188.68.38.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5ED4B73073; Tue, 29 Aug 2017 22:12:37 +0000 (UTC) (envelope-from jmd@freebsd.org) Received: from mailman (www.poelloepaeae.de [192.168.1.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by www.poelloepaeae.de (Postfix) with ESMTPSA id 0004D18811B; Tue, 29 Aug 2017 22:53:51 +0200 (CEST) From: Johannes M Dieterich To: Jung-uk Kim Cc: Jan Beich , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r448928 - in head/graphics: . drm-next-kmod In-Reply-To: Message-ID: <20170829205351.Horde.cJ-BkOZLFgXWSRXmqFSiczx@www.poelloepaeae.de> User-Agent: Horde Application Framework 5 Date: Tue, 29 Aug 2017 20:53:51 +0000 Content-Type: text/plain; charset=utf-8 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2017 22:12:38 -0000 Jung-uk Kim – Tue., 29. August 2017 16:46 > On 08/29/2017 13:13, Jan Beich wrote: > > Johannes M Dieterich writes: > > > >> Author: jmd > >> Date: Tue Aug 29 16:32:19 2017 > >> New Revision: 448928 > >> URL: svnweb.freebsd.org/changeset/ports/448928 > >> > >> Log: > >> New port: graphics/drm-next-kmod. > > [...] > >> +USES= kmod uidfix > > > > Fails to build if SRC_BASE != /usr/src. With SRCTOP undefined the port > > relies on /sys symlink existing and pointing to a real location. The > > latter conflicts with $SRC_BASE/etc/Makefile hardcoding "usr/src/sys". > > > > Maybe add MAKE_ENV = SRCTOP="${SRC_BASE}" to fix the following. > > > > $ make DISABLE_MAKE_JOBS= > > ===> Building for drm-next-kmod-g20170825 > > ===> drm (all) > > Warning: Object directory not changed from original /usr/ports/graphics/drm-next-kmod/work/kms-drm-4ee5acb/drm > > ===> amd (all) > > make[3]: "/usr/ports/graphics/drm-next-kmod/work/kms-drm-4ee5acb/amd/Makefile" line 3: Cannot open /sys/conf/kern.opts.mk > > make[3]: Fatal errors encountered -- cannot continue > > make[3]: stopped in /usr/ports/graphics/drm-next-kmod/work/kms-drm-4ee5acb/amd > > *** Error code 1 I can add this, however, my understanding is that for kmods we require /usr/src? I checked with kwm and he pointed out that people not running /non-usr/src systems should set SRC_BASE properly in their Mk/Uses/kmod.mk (I haven't tested this). > Also, please fix non-root build while you're at it. Please see the > attached patch. Yes, there is a bugzilla entry already for this. See my response there, I also need to sort out the weird licensing of these modules for packaging and will include the other changes with that. Thanks, Johannes