From owner-freebsd-standards@FreeBSD.ORG Tue Oct 22 19:09:07 2013 Return-Path: Delivered-To: freebsd-standards@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 5F41BDD3 for ; Tue, 22 Oct 2013 19:09:07 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-oa0-f48.google.com (mail-oa0-f48.google.com [209.85.219.48]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 251AF2051 for ; Tue, 22 Oct 2013 19:09:07 +0000 (UTC) Received: by mail-oa0-f48.google.com with SMTP id m17so7045445oag.35 for ; Tue, 22 Oct 2013 12:09:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=x0O5OV1XLR2aNC/tXMe0CqAcxcgGLE/tPI1MqCSedE8=; b=ElgkHdXnqyT0dmosWRD+DHTgf/+NM1+XxVZq5BoEplPL5kRg0hQ00aNYquR9j+O2so Cme6xeQqOcu1ocjCq6K8wHdUzTZAWwx5RK3tKkjn9oY7guxnd0rllHhgyhLISl5JTjZA th/i6wRqC5g2liDMkDP+qDaMuAy4YKxm1f4yCOq3sBPmRbXduHOB25eE64XP+rP5tySF Uxkf17e+i7R3+dFu97VP/ueI95UKbcnmNqiUmMZXesMeWe0lKtOLpqaKiNCDE5ECsCAX cwZfhv6aL15QbAy7E4MeSBVmeiMSAiLXpeKMoQM0SUF03wm+rNUPLJ3Tot0jrPRfREkK /oqA== X-Gm-Message-State: ALoCoQnziGtq3FzAVGHJjk9XJ3Vg/eXn8p/fJAYa8msMLPonAlibuGhchkTA5/sohVcAR+VPn53Z X-Received: by 10.182.213.39 with SMTP id np7mr20962obc.92.1382468940028; Tue, 22 Oct 2013 12:09:00 -0700 (PDT) Received: from monkey-bot.int.fusionio.com ([209.117.142.2]) by mx.google.com with ESMTPSA id z5sm42667147obg.13.2013.10.22.12.08.58 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 22 Oct 2013 12:08:58 -0700 (PDT) Sender: Warner Losh Subject: Re: VLC 2.1.0 Mime-Version: 1.0 (Apple Message framework v1085) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: <20131022174715.59433270@kalimero.tijl.coosemans.org> Date: Tue, 22 Oct 2013 13:08:56 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20131022152502.61214646@kalimero.tijl.coosemans.org> <20131022174715.59433270@kalimero.tijl.coosemans.org> To: Tijl Coosemans X-Mailer: Apple Mail (2.1085) Cc: multimedia-list freebsd , William Grzybowski , freebsd-standards@FreeBSD.org X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Oct 2013 19:09:07 -0000 On Oct 22, 2013, at 9:47 AM, Tijl Coosemans wrote: > On Tue, 22 Oct 2013 12:30:38 -0200 William Grzybowski wrote: >> On Tue, Oct 22, 2013 at 11:25 AM, Tijl Coosemans = wrote: >>> On Tue, 22 Oct 2013 10:55:28 -0200 William Grzybowski wrote: >>>> I am trying to update vlc to 2.1.0, its the final step to get rid = of >>>> ffmpeg1 as well. >>>> I was wondering if any c++ guru out there have any clues on how to = fix this: >>>>=20 >>>> http://pastebin.ca/2469885 >>>>=20 >>>> http://people.freebsd.org/~wg/vlc2.1.0.txt >>>=20 >>> I think the problem is that clang doesn't expect } after a label. >>> So try adding a ; or (void)0; between the label and = vlc_cleanup_run(). >>=20 >> That works, thank you! >=20 > I suspect that clang is correct to complain about this and if so we > might want to add (void)0; to the definition of pthread_cleanup_pop > in /usr/include/pthread.h. Let's see what -standards has to say > about this. >=20 > Summarised: the idiom that VLC uses is this: >=20 > pthread_cleanup_push(...); > ... > if (error) goto cleanup; > ... > cleanup: > pthread_cleanup_pop(...); >=20 > Because the definition of the pthread_cleanup_pop macro starts with } > clang complains. Any statement will do there... Clang is correct in complaining because a = label in C labels the statement not the location. (void) 0; is as good or bad as any... Warner=