From owner-cvs-all@FreeBSD.ORG Fri Nov 16 23:21:32 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DD89E16A41B; Fri, 16 Nov 2007 23:21:32 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 8BD9113C474; Fri, 16 Nov 2007 23:21:32 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id lAGNLQ7t036205; Fri, 16 Nov 2007 16:21:27 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <473E25F5.1090805@samsco.org> Date: Fri, 16 Nov 2007 16:21:25 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: Poul-Henning Kamp References: <33907.1195254953@critter.freebsd.dk> In-Reply-To: <33907.1195254953@critter.freebsd.dk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Fri, 16 Nov 2007 16:21:27 -0700 (MST) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, =?ISO-8859-1?Q?S=F8ren_Schmidt?= , Nate Lawson Subject: Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Nov 2007 23:21:33 -0000 Poul-Henning Kamp wrote: > In message <473E238D.4030800@samsco.org>, Scott Long writes: >> Poul-Henning Kamp wrote: > >>>> Well, there are two questions: media present (yes/no) and drive capable >>>> of telling if media present without just trying to read it (yes/no). >>> This risk reopening the old religious war if drivers should poll >>> their drives to be up to date on media existence. >> This has nothing to do with polling, you're just trotting out an >> irrelevant argument to divert attention. > > No, I merely pointed out that Nates worries had an obvious and widely > accepted solution, which unfortunately is religiously unacceptable > in certain parts of FreeBSD storage subsystems. > > For all I know, the problem sos@ has complained about has a solution > that just needs somebody to change the relevant few lines of code. > Ok, back on track. What you want to do is make g_access largely irrelevant, and have the _real_ access check done in g_start. Fine. Is there any reason at all to make g_access not return success from now on? And if so, is there any reason to even keep it around? This is what I'm arguing against; you're advocating a hack that works well enough for you and ignoring the larger architectural issue, which I think is important. But anyways. Scott