From owner-svn-src-all@freebsd.org Sun Oct 22 12:10:02 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05360E513A5; Sun, 22 Oct 2017 12:10:02 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x22b.google.com (mail-pg0-x22b.google.com [IPv6:2607:f8b0:400e:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C3B6A638CF; Sun, 22 Oct 2017 12:10:01 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x22b.google.com with SMTP id j3so9776375pga.1; Sun, 22 Oct 2017 05:10:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc:message-id:references :to; bh=u1Y1l9Xi/gK4f5ZwIZJsk1YOVfKm0Rl1+wjH9z502GA=; b=A2AxzVOVbiWu8Px9TocEmQJqH03+2gVtfJHtS6XHIS2aCMshavSbb3EJ7b6KcgWhN4 ZgDgRiL9O81Rl3PXYZRPkhm3O8LGkrmFw1OP3MYUJtrcmWOay/omXThwJrb65e64yBQN vcq7K5iTNDt4l9tUByWNej9dSzKVWbsUqrKe1Kdfy9I03/qOASefLuwOJlHLLGuMp+87 64M6uHZ4sefBikM2a6nXFzX2W2vV7Yfiiahra+h58NEJMgI+MpBq5D/YuqG+mmHQGDCe jZiwm8BorQfJnTpf2gVEy1/VNHkRujTCWQT2uGW8A384JJiaBbWSIxBGCmzo34ko9JOP aSag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=u1Y1l9Xi/gK4f5ZwIZJsk1YOVfKm0Rl1+wjH9z502GA=; b=HGiYZHj36eofJOrIX5W3h4FzjGjPCcDuOGBp+QBwBZZlQSRuh3Rb7fIdoBNFF6nTny aeES1PgElN4Q8sBQ31i0T5SZKnTEWg0tHN5yio0TYI12GvCbGFruDcsQ5ypeXFhb2iqH 5bkvQHhbSUpLNkj1heFJbIuXdjU49o/nUYzerzQ7IYC719Iptmm/BmWAfvqS1Q0u6cwi aoraz7zri1pdGj+Grsz5jEMGg/sCeYJnC0ZZwSmHNKXVnvnDoUHo7/iR3O+I9gfwCcNj /KHvdq1dReLflEZ1MLZDtBIgigtySJtVhQr4kHwSLIEaRGB/N2sURi5B9UAQ8EDaUg1h f5TA== X-Gm-Message-State: AMCzsaURQhvOg+vTa4o88scBnlHWcg3wJtGRQZtH9OXMcw69hVT4qBOt zcm7Ib8GwUDxNfmzTdyBL1Ilvfm1 X-Google-Smtp-Source: ABhQp+Q2IlirHxJZVPEttQ7xJCu2CYIxY49KWSiexMsmloNBeLnXG5i1WMdPZVNOMfo5AjqK4QM+Tg== X-Received: by 10.159.216.141 with SMTP id s13mr8075557plp.377.1508674201007; Sun, 22 Oct 2017 05:10:01 -0700 (PDT) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id q69sm9907258pfg.127.2017.10.22.05.09.59 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 22 Oct 2017 05:10:00 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_AA8DD736-7FEF-4F86-A69F-8207A705B2D8"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r324789 - in head/sys: kern sys From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <201710200402.v9K42rFP029260@repo.freebsd.org> Date: Sun, 22 Oct 2017 05:09:58 -0700 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: References: <201710200402.v9K42rFP029260@repo.freebsd.org> To: Mateusz Guzik X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2017 12:10:02 -0000 --Apple-Mail=_AA8DD736-7FEF-4F86-A69F-8207A705B2D8 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Oct 19, 2017, at 21:02, Mateusz Guzik wrote: >=20 > Author: mjg > Date: Fri Oct 20 04:02:53 2017 > New Revision: 324789 > URL: https://svnweb.freebsd.org/changeset/base/324789 >=20 > Log: > Mark kdb_active as __read_frequently and switch to bool to eat less = space. >=20 > Modified: > head/sys/kern/subr_kdb.c > head/sys/sys/kdb.h >=20 > Modified: head/sys/kern/subr_kdb.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/kern/subr_kdb.c Fri Oct 20 03:38:58 2017 = (r324788) > +++ head/sys/kern/subr_kdb.c Fri Oct 20 04:02:53 2017 = (r324789) > @@ -50,7 +50,7 @@ __FBSDID("$FreeBSD$"); > #include > #endif >=20 > -int kdb_active =3D 0; > +bool __read_frequently kdb_active =3D 0; > static void *kdb_jmpbufp =3D NULL; > struct kdb_dbbe *kdb_dbbe =3D NULL; > static struct pcb kdb_pcb; >=20 > Modified: head/sys/sys/kdb.h > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/sys/kdb.h Fri Oct 20 03:38:58 2017 = (r324788) > +++ head/sys/sys/kdb.h Fri Oct 20 04:02:53 2017 = (r324789) > @@ -59,7 +59,7 @@ struct kdb_dbbe { > }; \ > DATA_SET(kdb_dbbe_set, name##_dbbe) >=20 > -extern int kdb_active; /* Non-zero while in = debugger. */ > +extern bool kdb_active; /* Non-zero while in = debugger. */ > extern int debugger_on_panic; /* enter the debugger on panic. = */ > extern struct kdb_dbbe *kdb_dbbe; /* Default debugger backend or = NULL. */ > extern struct trapframe *kdb_frame; /* Frame to kdb_trap(). */ This broke `kdb_active` use in `kdb_trap`. It=E2=80=99s noticed = by gcc on riscv64: = https://ci.freebsd.org/job/FreeBSD-head-riscv64-build/4356/console . Please fix or revert. Thanks, -Ngie --Apple-Mail=_AA8DD736-7FEF-4F86-A69F-8207A705B2D8 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE5bk3FaGcY5rvqmb79YOpJmkwhhUFAlnsipYACgkQ9YOpJmkw hhVczA/+I2F111hzAKbMczgzWnSejlmjugNFQb/Ot//CKXgO2qdzNIm3KfQnIU8l WhAZsQQGlUCKSBVkV5uBOBg2i5RrbB23ibnJ0a//CoAXa25V25Bj6juv3hreBoIE IneoXIhHLL7NRnqIEcZg01MynYbvlLm2iuUecj/tMBTLNMO2O4ELPNg0SlOhayLg 1Up3GJQuxpHuKAkLF85NQG99x4pnlDVbgMIikS9flRxtaRWIqIDlyPpFNqqriAdi rXrAu1GvpdGKQtSsJRWlkC3ML1+Ai6lNkkUf3DHrAtlmAwOO0ZwxrK5zqbtUXrZY hHPW42OFCwzMeyNw9V/j9XnLP7s2DckDb6PfrFgc0FmKe8ib0ydp0iw2ta0LVlfo Vrco8mgvLWrKPvJNqDcFhspv41mxftNXzBKUqmG5Hg+kBZXGttzlg7N6s66dABta adWbZAtLEb82zzs860dpmyshZGT3txPj/ewgWcB3qaU4bi/JENEqfM+MW7PI9ace J1dT9JlNsgAdWKlLcRyX8KSOrG4wFpsYxhXGe0/E/iKr5+fZjorKVaEhCsYLbxC3 tpguGl1+g1qtuQuavczibpzOXxaBVaVXC8+RQwBDn+QJDTO8R6EVCi04ZbKgDH5C FJpBDWci++ytilszqx73GhlwWM9pUF1rs1Jt3J7rGbtWk0wHSsY= =WM5Z -----END PGP SIGNATURE----- --Apple-Mail=_AA8DD736-7FEF-4F86-A69F-8207A705B2D8--