From owner-freebsd-ports@FreeBSD.ORG  Sun May  4 18:32:47 2014
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 123F0742
 for <freebsd-ports@freebsd.org>; Sun,  4 May 2014 18:32:47 +0000 (UTC)
Received: from fire.magemana.nl (magemana.nl [IPv6:2a01:7c8:aaae:25e::1])
 by mx1.freebsd.org (Postfix) with ESMTP id CE0B0132E
 for <freebsd-ports@freebsd.org>; Sun,  4 May 2014 18:32:46 +0000 (UTC)
Received: by fire.magemana.nl (Postfix, from userid 1003)
 id 43C3E4AB4F1; Sun,  4 May 2014 20:32:44 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
 by fire.magemana.nl (Postfix) with ESMTP id 3FC4E4AB4EE;
 Sun,  4 May 2014 20:32:44 +0200 (CEST)
Date: Sun, 4 May 2014 20:32:44 +0200 (CEST)
From: Melvyn Sopacua <melvyn@magemana.nl>
To: Marcin Wisnicki <mwisnicki+freebsd@gmail.com>
Subject: Re: make package no longer installing
In-Reply-To: <lk5l9p$g9g$2@ger.gmane.org>
Message-ID: <alpine.BSF.2.00.1405042019500.79927@fire.magemana.nl>
References: <lk5l9p$g9g$2@ger.gmane.org>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: freebsd-ports@freebsd.org
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 04 May 2014 18:32:47 -0000

HI Marcin,

On Sun, 4 May 2014, Marcin Wisnicki wrote:

> portupgrade -p invokes make with DEPENDS_TARGET=package[1] but this no
> longer installs dependencies. Which target or option should be used
> instead ?
>

I fixed this locally by creating a new target in Mk/bsd.local.mk:

full-package: install
 	@cd ${.CURDIR} && ${MAKE} package
 	@cd ${.CURDIR} && ${MAKE} package-links
 	@if [ -f ${PACKAGES}/All/${PKGNAME}${PKG_SUFX} ]; then \
 		${ECHO_MSG} Package installed in ${PACKAGES}/All/${PKGNAME}${PKG_SUFX}; \
 			else \
 				${ECHO_MSG} "Failed to save package"; \
 				exit 1; \
 			fi

You will need USE_LOCAL_MK=yes in /etc/make.conf.

The reason is that STAGE now abuses the package and install targets to
do the staged installations. Once the stage installation is done, the
package target reverts to it's old behavior of installing and packaging
the package. For some reason it doesn't invoke package-links anymore, so
I added as well.

Then you need to fix portupgrade to specify full-package as
DEPENDS_TARGET.
I tried DEPENDS_TARGET="install package" but it won't work, probably
because the cookie check that switches the package target is not
re-evaluated, but spawning a sub make does. I didn't check that
thoroughly.

--
Hope this helps,

Melvyn