Date: Fri, 16 Nov 2007 23:36:53 +0000 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Scott Long <scottl@samsco.org> Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@deepcore.dk>, Nate Lawson <nate@root.org> Subject: Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h Message-ID: <34234.1195256213@critter.freebsd.dk> In-Reply-To: Your message of "Fri, 16 Nov 2007 16:21:25 MST." <473E25F5.1090805@samsco.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <473E25F5.1090805@samsco.org>, Scott Long writes: >Ok, back on track. What you want to do is make g_access largely >irrelevant, and have the _real_ access check done in g_start. Fine. Only for drive mechanisms that require out of band ioctls issued over the inband channel in order to enable access to the media. In other words CD drives. >Is there any reason at all to make g_access not return success from >now on? g_access is also responsible for checking read/writeability of the media against the requested permissions. >is what I'm arguing against; you're advocating a hack that works well >enough for you and ignoring the larger architectural issue, which I >think is important. But anyways. I think you misunderstand something here. The only suggested change is that the printfs in geom gets supressed for this one particular errno. Nothing else changes as far as I know. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?34234.1195256213>