From owner-cvs-all Sun Dec 16 13:34: 1 2001 Delivered-To: cvs-all@freebsd.org Received: from iguana.aciri.org (iguana.aciri.org [192.150.187.36]) by hub.freebsd.org (Postfix) with ESMTP id 1770A37B416; Sun, 16 Dec 2001 13:33:58 -0800 (PST) Received: (from rizzo@localhost) by iguana.aciri.org (8.11.3/8.11.1) id fBGLXtH71484; Sun, 16 Dec 2001 13:33:55 -0800 (PST) (envelope-from rizzo) Date: Sun, 16 Dec 2001 13:33:55 -0800 From: Luigi Rizzo To: Warner Losh Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/sys sysctl.h src/sys/kern kern_sysctl.c src/sbin/sysctl sysctl.8 sysctl.c Message-ID: <20011216133355.A71423@iguana.aciri.org> References: <200112160255.fBG2tfi90738@freefall.freebsd.org> <200112160740.fBG7eCM68417@harmony.village.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200112160740.fBG7eCM68417@harmony.village.org> User-Agent: Mutt/1.3.23i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Dec 16, 2001 at 12:40:12AM -0700, Warner Losh wrote: > In message <200112160255.fBG2tfi90738@freefall.freebsd.org> Luigi Rizzo writes: > : Note to developers: have a look at your code, there are a number of > : variables which do not have a description. > > Someone else did this before, but phk backed it out because it didn't > do i18n. Looking at the commit logs, it seems that the reason was perceived code bloat. Maybe this is not an issue anymore, but just in case someone is interested, the kernel I am testing has a total of 552 sysctl vars (sysctl -dA), 323 of which have a non-empty description. Just the variable names (sysctl -A |awk '{print $1}' | wc -c) take ~12KB, whereas sysctl -dA | wc -c says 23050. Seems more than tolerable, it is just 1% of the kernel size. Compressed, these are 3415 and 7174 bytes respectively. cheers luigi ----------------------------------+----------------------------------------- Luigi RIZZO, luigi@iet.unipi.it . ACIRI/ICSI (on leave from Univ. di Pisa) http://www.iet.unipi.it/~luigi/ . 1947 Center St, Berkeley CA 94704 Phone: (510) 666 2927 ----------------------------------+----------------------------------------- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message