From owner-cvs-all  Thu Feb  1  9: 8:10 2001
Delivered-To: cvs-all@freebsd.org
Received: from panzer.kdm.org (panzer.kdm.org [216.160.178.169])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5CC8037B6A0; Thu,  1 Feb 2001 09:07:44 -0800 (PST)
Received: (from ken@localhost)
	by panzer.kdm.org (8.9.3/8.9.1) id KAA46014;
	Thu, 1 Feb 2001 10:07:43 -0700 (MST)
	(envelope-from ken)
Date: Thu, 1 Feb 2001 10:07:43 -0700
From: "Kenneth D. Merry" <ken@kdm.org>
To: "James E. Housley" <jeh@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: ports/misc/amanda24-server Makefile pkg-plist
Message-ID: <20010201100743.A45976@panzer.kdm.org>
References: <200102011259.f11CxtB64291@freefall.freebsd.org> <20010201095324.A45813@panzer.kdm.org> <3A799635.6BB47528@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2i
In-Reply-To: <3A799635.6BB47528@FreeBSD.org>; from jeh@FreeBSD.org on Thu, Feb 01, 2001 at 12:00:37PM -0500
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Thu, Feb 01, 2001 at 12:00:37 -0500, James E. Housley wrote:
> "Kenneth D. Merry" wrote:
> > 
> > On Thu, Feb 01, 2001 at 04:59:55 -0800, James E. Housley wrote:
> > > jeh         2001/02/01 04:59:55 PST
> > >
> > >   Modified files:
> > >     misc/amanda24-server Makefile pkg-plist
> > >   Log:
> > >   Up throught FreeBSD 3.x scsiio.h existed anc cause chg-scsi to be built.
> > >   After that, SCSI was CAMified and chg-scsi isn't built, but that is a
> > >   seperate problem.
> > >
> > >   Submitted by:       bento
> > 
> > CAM went into the tree in FreeBSD 3.0.
> > 
> > There are also 2.2.x versions out there with CAM patches applied.
> > 
> > The most reliable way to detect a CAM system, from a makefile, is:
> > 
> > .if exists(/usr/include/camlib.h)
> > ...CAM system...
> > .else
> > ...not a CAM system...
> > .endif
> 
> The ./configure looks for sys/scsiio.h, and that seemed to exist up
> through RELENG_3_5_0_RELEASE according to CVS, and that is what I based
> this upon.

It probably should have been deleted long before that.

The problem with looking for scsiio.h is that a pre-CAM system that has
been upgraded will likely have sys/scsiio.h.

So you'll get a lot of false positives.

It would be better to change the configure script to look for
/usr/include/camlib.h, and then assume a CAM system from that.  A non-CAM
system won't have that file.

Ken
-- 
Kenneth Merry
ken@kdm.org


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message