From owner-freebsd-ports@FreeBSD.ORG  Sat Jan 19 21:11:25 2013
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 4D1FF5C1;
 Sat, 19 Jan 2013 21:11:25 +0000 (UTC)
 (envelope-from nox@jelal.kn-bremen.de)
Received: from smtp.kn-bremen.de (gelbbaer.kn-bremen.de [78.46.108.116])
 by mx1.freebsd.org (Postfix) with ESMTP id 0DFB973;
 Sat, 19 Jan 2013 21:11:24 +0000 (UTC)
Received: by smtp.kn-bremen.de (Postfix, from userid 10)
 id DEA1F1E000C7; Sat, 19 Jan 2013 22:11:16 +0100 (CET)
Received: from triton8.kn-bremen.de (noident@localhost [127.0.0.1])
 by triton8.kn-bremen.de (8.14.5/8.14.4) with ESMTP id r0JL941K076435;
 Sat, 19 Jan 2013 22:09:04 +0100 (CET)
 (envelope-from nox@triton8.kn-bremen.de)
Received: (from nox@localhost)
 by triton8.kn-bremen.de (8.14.5/8.14.3/Submit) id r0JL93LO076434;
 Sat, 19 Jan 2013 22:09:03 +0100 (CET) (envelope-from nox)
From: Juergen Lock <nox@jelal.kn-bremen.de>
Date: Sat, 19 Jan 2013 22:09:03 +0100
To: freebsd-multimedia@FreeBSD.org, freebsd-ports@FreeBSD.org
Subject: CFT: building multimedia/vlc with clang on 9.1+
Message-ID: <20130119210903.GA76282@triton8.kn-bremen.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 19 Jan 2013 21:11:25 -0000

Hi!

 As having to depend on gcc 4.6+ on i386 is kindof a waste on 9.1+
where we have clang too, and clang might generate better code than
the old gcc 4.2.1 in base on amd64 anyway I thought what if we have
the vlc port default to using clang on 9.1+ when it's available?
So I propse the patch below for testing by anyone on 9.1 or later,
also on i386 where I can't test myself, please report any issues
or regressions you find.

 Thanx!
	Juergen

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/multimedia/vlc/Makefile,v
retrieving revision 1.312
diff -u -p -r1.312 Makefile
--- Makefile	12 Jan 2013 20:25:57 -0000	1.312
+++ Makefile	19 Jan 2013 20:45:39 -0000
@@ -679,9 +679,16 @@ IGNORE=		base clang version too old, set
 CONFIGURE_ARGS+=--enable-altivec # VLC's config script doesn't know to do this
 .endif
 
+# prefer clang on 9.1+
+.if (${OSVERSION} >= 901000) && exists(${DESTDIR}/usr/bin/clang)
+CC=	clang
+CXX=	clang++
+CPP=	clang-cpp
+.else
 .if ${ARCH} == "i386"
 USE_GCC?=	4.6+ # sse/3dnow detection on i386 needs newer gcc
 .endif
+.endif
 
 # End OS specific hacks