From owner-freebsd-acpi@FreeBSD.ORG Sat Dec 1 09:10:04 2012 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AC89D30C; Sat, 1 Dec 2012 09:10:04 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id C5B978FC08; Sat, 1 Dec 2012 09:10:03 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id LAA28130; Sat, 01 Dec 2012 11:10:02 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1Tej5G-0004zI-7b; Sat, 01 Dec 2012 11:10:02 +0200 Message-ID: <50B9C968.70804@FreeBSD.org> Date: Sat, 01 Dec 2012 11:10:00 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: =?ISO-8859-1?Q?Jean-S=E9bastien_P=E9dron?= Subject: Re: [rfc] bind curthread to target cpu for _CST change notification References: <50AE3C66.2050207@FreeBSD.org> <1353872249.20189.3.camel@powernoodle> <50B77F4B.8070701@FreeBSD.org> <50B8951D.1000609@FreeBSD.org> <50B9C7B6.1040306@FreeBSD.org> In-Reply-To: <50B9C7B6.1040306@FreeBSD.org> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Cc: freebsd-acpi@FreeBSD.org X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Dec 2012 09:10:04 -0000 on 01/12/2012 11:02 Jean-Sébastien Pédron said the following: > On 30.11.2012 12:14, Andriy Gapon wrote: >> Here is my WIP: http://people.freebsd.org/~avg/acpi_cpu_notify.2.diff > > Hi Andriy! > > I tried your last patch and it fixed a page fault I had since r243404 (I > couldn't investigate the problem before this week-end). > > This page fault corresponds to the point #2 of your patch ("avoid race > acpi_cpu_cx_cst and acpi_cpu_idle"). In my case, acpi_cpu_cx_cst is > triggered every 10 seconds (I don't know if it's expected). This frees > cx_ptr->p_lvlx each time (new in r243404), and concurrently, > CPU_GET_REG(cx_next->p_lvlx, 1) causes the page fault in acpi_cpu_idle(). Thank you for testing! I will commit this patch soon. > By the way, should _CST appear in a dump from acpidump(8)? Yes, it depends... :-) _CST could be defined in a dynamically loadable region. If you do not see _CST in the DSDT but see Load() calls, then that's the most likely explanation. -- Andriy Gapon