From owner-freebsd-current@FreeBSD.ORG Thu Dec 2 15:10:52 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 61F5716A4CE; Thu, 2 Dec 2004 15:10:52 +0000 (GMT) Received: from relay.bestcom.ru (relay.bestcom.ru [217.72.144.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9E56843D55; Thu, 2 Dec 2004 15:10:51 +0000 (GMT) (envelope-from glebius@freebsd.org) Received: from cell.sick.ru (root@cell.sick.ru [217.72.144.68]) by relay.bestcom.ru (8.13.1/8.12.9) with ESMTP id iB2FAnUu002382 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Thu, 2 Dec 2004 18:10:50 +0300 (MSK) (envelope-from glebius@freebsd.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.12.11/8.12.8) with ESMTP id iB2FAmo2033695 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 2 Dec 2004 18:10:49 +0300 (MSK) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.sick.ru (8.12.11/8.12.11/Submit) id iB2FAmXX033694; Thu, 2 Dec 2004 18:10:48 +0300 (MSK) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@freebsd.org using -f Date: Thu, 2 Dec 2004 18:10:48 +0300 From: Gleb Smirnoff To: current@freebsd.org, stable@freebsd.org Message-ID: <20041202151048.GA33485@cell.sick.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline User-Agent: Mutt/1.5.6i X-Virus-Scanned: clamd / ClamAV version devel-20041013, clamav-milter version 0.75l on 127.0.0.1 X-Virus-Status: Clean Subject: [TEST] netgraph callout interface X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Dec 2004 15:10:52 -0000 Dear collegues, we are working on making netgraph ISR mpsafe. To do it we need to fix all (ab)users of bare timeout(9) in src/sys/netgraph. These timeout calls are running in synch with netgraph now because timeout(9) is Giant-locked. As soon as we mark ISR mpsafe, they are going to break. This patch semi-mechanically changes all timeout(9) calls to ng_callout(9), which runs scheduled callouts in netgraph context: http://people.freebsd.org/~glebius/totest/netgraph_callout It can be applied to HEAD or RELENG_5 (not 5.3-RELEASE). It patches the following nodes: ng_bridge.c ng_l2tp.c ng_lmi.c ng_ppp.c ng_pppoe.c ng_tty.c If you are using at least one of them, then I'm asking you to test the patch and respond. Thanks in advance! P.S. Sorry for crossposting. The target users are both RELENG_5 and CURRENT. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE