From owner-cvs-all Thu Sep 20 6:54:12 2001 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (gw.Awfulhak.org [217.204.245.18]) by hub.freebsd.org (Postfix) with ESMTP id E831037B408; Thu, 20 Sep 2001 06:53:59 -0700 (PDT) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [fec0::1:12]) by Awfulhak.org (8.11.6/8.11.6) with ESMTP id f8KDrtt14156; Thu, 20 Sep 2001 14:53:58 +0100 (BST) (envelope-from brian@freebsd-services.com) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.6/8.11.6) with ESMTP id f8KDrpR40559; Thu, 20 Sep 2001 14:53:51 +0100 (BST) (envelope-from brian@freebsd-services.com) Message-Id: <200109201353.f8KDrpR40559@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Ruslan Ermilov Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@freebsd-services.com Subject: Re: cvs commit: src/sys/net rtsock.c In-Reply-To: Message from Ruslan Ermilov of "Thu, 20 Sep 2001 01:25:25 PDT." <200109200825.f8K8PPQ79587@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 20 Sep 2001 14:53:51 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > ru 2001/09/20 01:25:25 PDT > > Modified files: > sys/net rtsock.c > Log: > Use the current process's credentials rather than socket's cached. > If the process drops its super-user privileges, we certainly don't > want to allow it to modify routing tables. > > Discussed with: rwatson > > Revision Changes Path > 1.58 +3 -3 src/sys/net/rtsock.c I can't upgrade any of my current boxes at the moment, but I suspect this *may* break usr.sbin/ppp/arp.c (the write() on line 136 needs to change to ID0write()). This can be tested by setting up a dialin to be assigned an IP address that's part of a LAN that's connected to the server, and adding ``enable proxy'' to the server config. If you can't test it right now, could you change the write() to ID0 write() and I'll check things when I'm in a more stable position ? Thanks. -- Brian http://www.freebsd-services.com/ Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message