Date: 03 Feb 2002 23:01:03 +0100 From: Dag-Erling Smorgrav <des@ofug.org> To: Mark Murray <markm@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libpam/modules/pam_lastlog pam_lastlog.c src/lib/libpam/modules/pam_login_access login_access.c pam_login_access.c pam_login_access.h src/lib/libpam/modules/pam_securetty pam_securetty.c src/lib/libpam/modules/pam_unix pam_unix.c Message-ID: <xzpr8o2p6n4.fsf@flood.ping.uio.no> In-Reply-To: <200202031517.g13FHwb73258@freefall.freebsd.org> References: <200202031517.g13FHwb73258@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Mark Murray <markm@FreeBSD.org> writes: > markm 2002/02/03 07:17:57 PST > > Modified files: > lib/libpam/modules/pam_lastlog pam_lastlog.c > lib/libpam/modules/pam_login_access login_access.c > pam_login_access.c > lib/libpam/modules/pam_securetty pam_securetty.c > lib/libpam/modules/pam_unix pam_unix.c > Added files: > lib/libpam/modules/pam_login_access pam_login_access.h > Log: > WARNS=n fixes (and some stylistic issues). You've introduced memory leaks and potential segfaults in pam_unix() (you added strdup()s in several places but you don't check the return value and don't free() them later). Other stuff: - pam_securetty should use _PATH_DEV instead of TTY_PREFIX - some long lines should be split (have to ask bde about that) - commit included non-trivial changes to salt generation which should have been mentioned in log message (others would say they should have been committed separately, but I don't mind) DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzpr8o2p6n4.fsf>