From owner-svn-src-stable-10@FreeBSD.ORG Wed Jun 4 21:17:24 2014 Return-Path: Delivered-To: svn-src-stable-10@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F099F94E; Wed, 4 Jun 2014 21:17:23 +0000 (UTC) Received: from smtp.digiware.nl (smtp.digiware.nl [31.223.170.169]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ADCC825D2; Wed, 4 Jun 2014 21:17:22 +0000 (UTC) Received: from rack1.digiware.nl (unknown [127.0.0.1]) by smtp.digiware.nl (Postfix) with ESMTP id 280CC1534D1; Wed, 4 Jun 2014 23:17:13 +0200 (CEST) X-Virus-Scanned: amavisd-new at digiware.nl Received: from smtp.digiware.nl ([127.0.0.1]) by rack1.digiware.nl (rack1.digiware.nl [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QYM9FXS0Q5Qx; Wed, 4 Jun 2014 23:17:11 +0200 (CEST) Received: from [192.168.10.9] (vaio [192.168.10.9]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by smtp.digiware.nl (Postfix) with ESMTPSA id 4163E153434; Wed, 4 Jun 2014 23:17:11 +0200 (CEST) Message-ID: <538F8CDE.3010302@digiware.nl> Date: Wed, 04 Jun 2014 23:17:18 +0200 From: Willem Jan Withagen User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: John Baldwin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r267071 - stable/10/usr.sbin/bhyve References: <201406041808.s54I88qm034126@svn.freebsd.org> In-Reply-To: <201406041808.s54I88qm034126@svn.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-stable-10@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for only the 10-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jun 2014 21:17:24 -0000 On 4-6-2014 20:08, John Baldwin wrote: > Author: jhb > Date: Wed Jun 4 18:08:08 2014 > New Revision: 267071 > URL: http://svnweb.freebsd.org/changeset/base/267071 > > Log: > MFC 260999: > Increase the block-layer backend maximum number of requests to match > the AHCI command queue depth. > > Modified: > stable/10/usr.sbin/bhyve/block_if.c > Directory Properties: > stable/10/ (props changed) > > Modified: stable/10/usr.sbin/bhyve/block_if.c > ============================================================================== > --- stable/10/usr.sbin/bhyve/block_if.c Wed Jun 4 17:57:48 2014 (r267070) > +++ stable/10/usr.sbin/bhyve/block_if.c Wed Jun 4 18:08:08 2014 (r267071) > @@ -50,7 +50,7 @@ __FBSDID("$FreeBSD$"); > > #define BLOCKIF_SIG 0xb109b109 > > -#define BLOCKIF_MAXREQ 16 > +#define BLOCKIF_MAXREQ 32 > > enum blockop { > BOP_READ, I once asked Peter about this, because of the trouble I had when running the bhyve_svm branch. This is not perse a good enhancement.... I've had a combination of HEAD and bhyve where running Linux and AMD would regularly generate timeouts for FPDMA for slots > 16.... After building the most recent bhyve_svm with patch set to get to a more recent almost-head-snapshot I ran some test, and did not run into these timeouts. So can very well be that fixes in HEAD got ride off the timeout. But then again I would say: thread with caution. --WjW