From owner-cvs-all@FreeBSD.ORG Tue Feb 8 15:54:30 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D975016A4CE; Tue, 8 Feb 2005 15:54:30 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C35C343D1D; Tue, 8 Feb 2005 15:54:30 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j18FsULW064912; Tue, 8 Feb 2005 15:54:30 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j18FsUkm064911; Tue, 8 Feb 2005 15:54:30 GMT (envelope-from phk) Message-Id: <200502081554.j18FsUkm064911@repoman.freebsd.org> From: Poul-Henning Kamp Date: Tue, 8 Feb 2005 15:54:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/ufs/ffs ffs_vnops.c src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Feb 2005 15:54:31 -0000 phk 2005-02-08 15:54:30 UTC FreeBSD src repository Modified files: sys/ufs/ffs ffs_vnops.c sys/ufs/ufs ufs_vnops.c Log: For snapshots we need all VOP_LOCKs to be exclusive. The "business class upgrade" was implemented in UFS's VOP_LOCK implementation ufs_lock() which is the wrong layer, so move it to ffs_lock(). Also, as long as we have not abandonned advanced vfs-stacking we should not preclude it from happening: instead of implementing a copy locally, use the VOP_LOCK_APV(&ufs) to correctly arrive at vop_stdlock() at the bottom. Revision Changes Path 1.149 +24 -0 src/sys/ufs/ffs/ffs_vnops.c 1.263 +0 -29 src/sys/ufs/ufs/ufs_vnops.c