Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 21 Sep 2019 13:00:38 +0000 (UTC)
From:      Alan Somers <asomers@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-releng@freebsd.org
Subject:   svn commit: r352573 - releng/12.1/sys/fs/fuse
Message-ID:  <201909211300.x8LD0cnx063405@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: asomers
Date: Sat Sep 21 13:00:38 2019
New Revision: 352573
URL: https://svnweb.freebsd.org/changeset/base/352573

Log:
  MF stable/12 r352534:
  
  Fix an off-by-one error from r351961
  
  That revision addressed a Coverity CID that could lead to a buffer overflow,
  but it had an off-by-one error in the buffer size check.
  
  Approved by: re (kib)
  Reported by: Coverity
  Coverity CID: 1405530
  MFC-With: 351961
  Sponsored by: The FreeBSD Foundation

Modified:
  releng/12.1/sys/fs/fuse/fuse_internal.c
Directory Properties:
  releng/12.1/   (props changed)

Modified: releng/12.1/sys/fs/fuse/fuse_internal.c
==============================================================================
--- releng/12.1/sys/fs/fuse/fuse_internal.c	Sat Sep 21 12:33:41 2019	(r352572)
+++ releng/12.1/sys/fs/fuse/fuse_internal.c	Sat Sep 21 13:00:38 2019	(r352573)
@@ -390,7 +390,7 @@ fuse_internal_invalidate_entry(struct mount *mp, struc
 	if ((err = uiomove(&fnieo, sizeof(fnieo), uio)) != 0)
 		return (err);
 
-	if (fnieo.namelen > sizeof(name))
+	if (fnieo.namelen >= sizeof(name))
 		return (EINVAL);
 
 	if ((err = uiomove(name, fnieo.namelen, uio)) != 0)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201909211300.x8LD0cnx063405>