From owner-freebsd-current  Wed Feb 27  7:15: 3 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id AB34537B417; Wed, 27 Feb 2002 07:14:57 -0800 (PST)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id CAA11204;
	Thu, 28 Feb 2002 02:14:55 +1100
Date: Thu, 28 Feb 2002 02:15:24 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender:  <bde@gamplex.bde.org>
To: Doug Barton <DougB@FreeBSD.org>
Cc: Bill Fenner <fenner@research.att.com>, <current@FreeBSD.org>
Subject: Re: Broken (?) unistd.h
In-Reply-To: <20020227014559.O31146-100000@master.gorean.org>
Message-ID: <20020228021250.Y49219-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On Wed, 27 Feb 2002, Doug Barton wrote:

> On Wed, 27 Feb 2002, Bruce Evans wrote:
> > >From style(9):
> >
> >      Kernel include files (i.e. sys/*.h) come first; normally, include
> >      <sys/types.h> OR <sys/param.h>, but not both.  <sys/types.h> includes
> >      <sys/cdefs.h>, and it is okay to depend on that.
>
> Based on a suggestion from someone else, I actually generated the same
> patch that Bill did. Without including sys/param.h, there is no definition
> of __FreeBSD_version at this point in the process, so the test always
> fails. If there is a more correct way to test, I'll be glad to use it,
> otherwise I'll have to go with what works.

Include the necessary header, but not both.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message