Date: Sat, 24 Sep 2005 15:46:56 -0700 From: Nate Lawson <nate@root.org> To: Poul-Henning Kamp <phk@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys bus.h rman.h types.h src/sys/kern subr_bus.c Message-ID: <4335D760.9080007@root.org> In-Reply-To: <20050924193119.F1A8A16A448@hub.freebsd.org> References: <20050924193119.F1A8A16A448@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Poul-Henning Kamp wrote: > --- src/sys/sys/bus.h:1.71 Sun Sep 18 01:32:09 2005 > +++ src/sys/sys/bus.h Sat Sep 24 19:31:10 2005 > @@ -85,11 +85,6 @@ > const char *__type, const char *__data); > void devctl_queue_data(char *__data); > > -/* > - * Forward declarations > - */ > -typedef struct device *device_t; > - > /** > * @brief A device driver (included mainly for compatibility with > * FreeBSD 4.x). > diff -u src/sys/sys/types.h:1.92 src/sys/sys/types.h:1.93 > --- src/sys/sys/types.h:1.92 Tue May 31 15:18:17 2005 > +++ src/sys/sys/types.h Sat Sep 24 19:31:10 2005 > @@ -285,6 +285,7 @@ > typedef __uintfptr_t uintfptr_t; > typedef __uint64_t uoff_t; > typedef struct vm_page *vm_page_t; > +typedef struct device *device_t; > > #define offsetof(type, field) __offsetof(type, field) I don't think our device_t definition belongs in sys/types.h. It is opaque for a reason. -- Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4335D760.9080007>