Date: Wed, 13 Oct 2010 14:59:22 GMT From: Alexander <bas@it-core.org> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/151430: [patch] net-mgmt/kismet fails to build with plugins Message-ID: <201010131459.o9DExMM2000572@www.freebsd.org> Resent-Message-ID: <201010131500.o9DF0GOq046562@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 151430
>Category: ports
>Synopsis: [patch] net-mgmt/kismet fails to build with plugins
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Oct 13 15:00:16 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Alexander
>Release: 8.1-RELEASE
>Organization:
>Environment:
FreeBSD vbox 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Mon Jul 19 02:55:53 UTC 2010 root@almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386
>Description:
First:
-----
In Makefile.inc.in:
..
PLUGINLDFLAGS = @PLUGINLDFLAGS@
..
In FreeBSD kismet configures with empty @PLUGINLDFLAGS@, so PLUGINLDFLAGS in Makefile.inc has empty value.
In plugins Makefiles:
..
PLUGINLDFLAGS ?= $(LDFLAGS)
..
so, plugin fails to build without any LDFLAGS.
I suggest to remove "PLUGINLDFLAGS = @PLUGINLDFLAGS@" from Makefile.inc.in.
Second:
-----
In /usr/ports/net-mgmt/kismet/Makefile:
..
${REINPLACE_CMD} -e "s/plugin-/plugin-[aps]/" \
..
so, builds only plugin-autowep, plugin-ptw & plugin-spectools, without plugin-btscan.
>How-To-Repeat:
# cd /usr/ports/net-mgmt/kismet
# make config
Enable PLUGINS option
>Fix:
In attached patch.
Patch attached with submission follows:
diff -U3 /usr/ports/net-mgmt/kismet.orig/Makefile /usr/ports/net-mgmt/kismet/Makefile
--- /usr/ports/net-mgmt/kismet.orig/Makefile 2010-10-03 07:42:20.000000000 +0000
+++ /usr/ports/net-mgmt/kismet/Makefile 2010-10-13 14:51:41.000000000 +0000
@@ -80,10 +80,11 @@
-e "/ouifile=/{/wireshark/d;s|/etc|${DOCSDIR}|;}" \
${WRKSRC}/conf/kismet.conf.in \
${WRKSRC}/conf/kismet_drone.conf
- ${REINPLACE_CMD} -e "s/plugin-/plugin-[aps]/" \
- -e "s/make/${GMAKE}/" \
+ ${REINPLACE_CMD} -e "s/make/${GMAKE}/" \
-e "s/\$$(MAKE)/${GMAKE}/" \
${WRKSRC}/Makefile.in
+ ${REINPLACE_CMD} -e 's/^PLUGINLDFLAGS[^$$]*//' \
+ ${WRKSRC}/Makefile.inc.in
post-install:
.ifndef(NOPORTDOCS)
Common subdirectories: /usr/ports/net-mgmt/kismet.orig/files and /usr/ports/net-mgmt/kismet/files
diff -U3 /usr/ports/net-mgmt/kismet.orig/pkg-plist /usr/ports/net-mgmt/kismet/pkg-plist
--- /usr/ports/net-mgmt/kismet.orig/pkg-plist 2010-10-03 07:42:20.000000000 +0000
+++ /usr/ports/net-mgmt/kismet/pkg-plist 2010-10-13 14:52:02.000000000 +0000
@@ -9,6 +9,7 @@
etc/kismet_drone.conf.sample
%%PLUGINS%%lib/kismet/aircrack-kismet.so
%%PLUGINS%%lib/kismet/autowep-kismet.so
+%%PLUGINS%%lib/kismet/btscan.so
%%PLUGINS%%lib/kismet/spectool_net.so
%%PLUGINS%%lib/kismet_client/spectools_ui.so
%%DATADIR%%/wav/alert.wav
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201010131459.o9DExMM2000572>