Date: Sat, 17 Aug 2002 02:31:49 -0700 From: Maxime Henrion <mux@freebsd.org> To: Terry Lambert <tlambert2@mindspring.com> Cc: stable@freebsd.org, jlemon@freebsd.org Subject: Re: PATCH2: Better kqueue patches Message-ID: <20020817093149.GL14155@elvis.mu.org> In-Reply-To: <3D5E0E57.3CCF4F70@mindspring.com> References: <3D5E0E57.3CCF4F70@mindspring.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Terry Lambert wrote: > OK, these patches still add support for System V message queue > integration into kqueue. They also fix the problems I noted > before, by adding a third parameter to KNOTE(), and fixing up > the kn_fop->f_event() functions to take a third parameter. > > This fixes the message queue ID > 65536 problem, and also fixes > the event/hint mux problem with signal and proc notes (particularly, > it allows for more than 20 bits of PID, if that's ever considered > desirable at some point). > > It also adds support for a virtual event, if the System V message > queue was not empty when the filter is first attached, to avoid > the need to do the poll-after-attach, and to poll on reads to avoid > the potential race condition (you would still need this for multiple > readers on the same queue, though... obviously). > > I think this code is OK to commit, if someone want to review it and > commit it. > > Context diffs vs. -STABLE attached. If you want to get this committed, it would probably help if you could generate diffs against -CURRENT. Also, not being a sysV nor a kqueue expert, your patch looks very nice. Just one small nit: malloc() with the M_WAITOK flag can't return NULL, so it's useless to test the pointer against NULL. Cheers, Maxime To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020817093149.GL14155>