Date: Fri, 4 May 2018 16:51:52 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: Don Whitteker <dwhitteker@gmail.com>, freebsd-acpi@freebsd.org Subject: Re: Temorarily disabling ACPI errors Message-ID: <59b7775a-e3b4-29d0-65b6-bee8a553604a@FreeBSD.org> In-Reply-To: <CAD%2BrCY2tykWODkV9_E0_9FeONkMEUuL4j7Na%2BfUdgxeypFEX7g@mail.gmail.com> References: <CAD%2BrCY2tykWODkV9_E0_9FeONkMEUuL4j7Na%2BfUdgxeypFEX7g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UwvlXFn74tc2JdIzk2MqDJaurnR8BqsnT Content-Type: multipart/mixed; boundary="vcUApmQXb3verHrl0PUESNoPkW20kf28V"; protected-headers="v1" From: Jung-uk Kim <jkim@FreeBSD.org> To: Don Whitteker <dwhitteker@gmail.com>, freebsd-acpi@freebsd.org Message-ID: <59b7775a-e3b4-29d0-65b6-bee8a553604a@FreeBSD.org> Subject: Re: Temorarily disabling ACPI errors References: <CAD+rCY2tykWODkV9_E0_9FeONkMEUuL4j7Na+fUdgxeypFEX7g@mail.gmail.com> In-Reply-To: <CAD+rCY2tykWODkV9_E0_9FeONkMEUuL4j7Na+fUdgxeypFEX7g@mail.gmail.com> --vcUApmQXb3verHrl0PUESNoPkW20kf28V Content-Type: multipart/mixed; boundary="------------C081B726836F99DFB71AF15A" Content-Language: en-US This is a multi-part message in MIME format. --------------C081B726836F99DFB71AF15A Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/04/2018 16:43, Don Whitteker wrote: > I am trying to temporarily disable my ACPI error messages I am getting = on > my laptop. I've tried disabling ACPI (crashed right at boot), tried > hw.acpi.osname=3D"Windows 2015" based on documentation and output from > 'acpidump -td | grep "Windows"'(no change), and even tried > 'hint.acpi_thermal.0.disabled=3D"1"' since the main issue are the therm= al > sensors. I know these issues need to be addressed and that I can't just= > sweep them under the rug. However I am getting spammed with 4 lines of > errors every 3-5 seconds. This is making it near impossible to type out= > anything but short commands at the prompt. I can't even open a file in = vi > to try to edit before the spam covers the first 4 lines and makes it > impossible to read or edit. I would love to tackle this problem and get= > ACPI working (if even only partially) but I can't do tanything with the= se > constant error messages. >=20 > Is there a way to pipe the error messages to /dev/null? I have done tha= t > using the find command and similar commands but I don't know how to whe= n > it's constantly coming from the system. Are you using head? If so, can you please try the attached patch? Thanks, Jung-uk Kim --------------C081B726836F99DFB71AF15A Content-Type: text/x-patch; name="acpi_rm_load_package_init.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="acpi_rm_load_package_init.diff" --- sys/contrib/dev/acpica/components/executer/exconfig.c +++ sys/contrib/dev/acpica/components/executer/exconfig.c @@ -615,6 +615,11 @@ AcpiExLoadOp ( return_ACPI_STATUS (Status); } =20 + /* Complete the initialization/resolution of package objects */ + + Status =3D AcpiNsWalkNamespace (ACPI_TYPE_PACKAGE, ACPI_ROOT_OBJECT,= + ACPI_UINT32_MAX, 0, AcpiNsInitOnePackage, NULL, NULL, NULL); + /* Store the DdbHandle into the Target operand */ =20 Status =3D AcpiExStore (DdbHandle, Target, WalkState); --- sys/contrib/dev/acpica/components/namespace/nsinit.c +++ sys/contrib/dev/acpica/components/namespace/nsinit.c @@ -406,6 +406,61 @@ ErrorExit: } =20 =20 +/***********************************************************************= ******** + * + * FUNCTION: AcpiNsInitOnePackage + * + * PARAMETERS: ObjHandle - Node + * Level - Current nesting level + * Context - Not used + * ReturnValue - Not used + * + * RETURN: Status + * + * DESCRIPTION: Callback from AcpiWalkNamespace. Invoked for every packa= ge + * within the namespace. Used during dynamic load of an SSD= T. + * + ***********************************************************************= *******/ + +ACPI_STATUS +AcpiNsInitOnePackage ( + ACPI_HANDLE ObjHandle, + UINT32 Level, + void *Context, + void **ReturnValue) +{ + ACPI_STATUS Status; + ACPI_OPERAND_OBJECT *ObjDesc; + ACPI_NAMESPACE_NODE *Node =3D (ACPI_NAMESPACE_NODE *) ObjHandle;= + + + ObjDesc =3D AcpiNsGetAttachedObject (Node); + if (!ObjDesc) + { + return (AE_OK); + } + + /* Exit if package is already initialized */ + + if (ObjDesc->Package.Flags & AOPOBJ_DATA_VALID) + { + return (AE_OK); + } + + Status =3D AcpiDsGetPackageArguments (ObjDesc); + if (ACPI_FAILURE (Status)) + { + return (AE_OK); + } + + Status =3D AcpiUtWalkPackageTree (ObjDesc, NULL, AcpiDsInitPackageEl= ement, + NULL); + + ObjDesc->Package.Flags |=3D AOPOBJ_DATA_VALID; + return (AE_OK); +} + + /***********************************************************************= ******** * * FUNCTION: AcpiNsInitOneObject --- sys/contrib/dev/acpica/include/acnamesp.h +++ sys/contrib/dev/acpica/include/acnamesp.h @@ -204,6 +204,12 @@ ACPI_STATUS AcpiNsInitializeDevices ( UINT32 Flags); =20 +ACPI_STATUS +AcpiNsInitOnePackage ( + ACPI_HANDLE ObjHandle, + UINT32 Level, + void *Context, + void **ReturnValue); =20 /* * nsload - Namespace loading --------------C081B726836F99DFB71AF15A-- --vcUApmQXb3verHrl0PUESNoPkW20kf28V-- --UwvlXFn74tc2JdIzk2MqDJaurnR8BqsnT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEl1bqgKaRyqfWXu/CfJ+WJvzb8UYFAlrsx+gACgkQfJ+WJvzb 8UacGQgAh8Ms6yt3H/2FJSxRM119LbPXg2UlP6r+refRbqiw+v7yF5rmDM3sb/N9 gAV/xPR4g3qMSDwYKP8sjLvlFtod6RK1vgZAW/GoffId7OtKBvURStsnfPlkdoQr MlR95jy+82RN28uzKKtWRrdNHlBZYjAkpHfOR7e8pzDoPZc2Ns2Hosxl706JYxxk 06+YFrtk+M9HN4OjmnyW9buCYmqImUUfRp2aSXECZgDVbBsrxGV2+iaa4vyEIyFb HarxvSeA1xMSlM1tqeuL8DuziGfetCerw2Lj3mIOxhPZQqVXoD6202+ldza/oDnH 5U2Go9Q7kEczdHvoLFoOUNuO9rIOhQ== =/Wwy -----END PGP SIGNATURE----- --UwvlXFn74tc2JdIzk2MqDJaurnR8BqsnT--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?59b7775a-e3b4-29d0-65b6-bee8a553604a>