Date: Fri, 24 May 2013 08:50:36 +0200 From: Michael Tuexen <tuexen@FreeBSD.org> To: "Bjoern A. Zeeb" <bz@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r250809 - head/sys/netinet Message-ID: <F8DDC452-016A-409B-87CF-1402DE7EE2E3@FreeBSD.org> In-Reply-To: <alpine.BSF.2.00.1305232136460.13079@ai.fobar.qr> References: <201305191606.r4JG6hNR032154@svn.freebsd.org> <alpine.BSF.2.00.1305232136460.13079@ai.fobar.qr>
next in thread | previous in thread | raw e-mail | index | archive | help
On May 23, 2013, at 11:37 PM, Bjoern A. Zeeb wrote: > On Sun, 19 May 2013, Michael Tuexen wrote: >=20 >> Author: tuexen >> Date: Sun May 19 16:06:43 2013 >> New Revision: 250809 >> URL: http://svnweb.freebsd.org/changeset/base/250809 >>=20 >> Log: >> Initialize the fibnum for outgoing packets to 0. This avoids >> crashing due to the usage of uninitialized fibnum. >> This bugs became visiable after >> http://svnweb.freebsd.org/changeset/base/250700 >=20 >=20 > That just masks the real bug, please back it out. And the real bug is that SCTP doesn't support multiple fibs, right? That would mean the system crashes on reception of an out of the blue SCTP packet... Best regards Michael >=20 >=20 >> MFC after: 2 weeks >>=20 >> Modified: >> head/sys/netinet/sctp_os_bsd.h >>=20 >> Modified: head/sys/netinet/sctp_os_bsd.h >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/netinet/sctp_os_bsd.h Sun May 19 15:26:15 2013 = (r250808) >> +++ head/sys/netinet/sctp_os_bsd.h Sun May 19 16:06:43 2013 = (r250809) >> @@ -435,6 +435,7 @@ typedef struct rtentry sctp_rtentry_t; >> { \ >> int o_flgs =3D IP_RAWOUTPUT; \ >> struct sctp_tcb *local_stcb =3D stcb; \ >> + M_SETFIB(o_pak, 0); \ >> if (local_stcb && \ >> local_stcb->sctp_ep && \ >> local_stcb->sctp_ep->sctp_socket) \ >> @@ -445,6 +446,7 @@ typedef struct rtentry sctp_rtentry_t; >> #define SCTP_IP6_OUTPUT(result, o_pak, ro, ifp, stcb, vrf_id) \ >> { \ >> struct sctp_tcb *local_stcb =3D stcb; \ >> + M_SETFIB(o_pak, 0); \ >> if (local_stcb && local_stcb->sctp_ep) \ >> result =3D ip6_output(o_pak, \ >> ((struct in6pcb = *)(local_stcb->sctp_ep))->in6p_outputopts, \ >>=20 >=20 > --=20 > Bjoern A. Zeeb ????????? ??? ??????? = ??????: > '??? ??? ???? ?????? ??????? ?? ?? ??????? ??????? ??? ????? ????? = ???? > ?????? ?? ????? ????', ????????? ?????????, "??? ????? ?? ?????", = ?.??? >=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F8DDC452-016A-409B-87CF-1402DE7EE2E3>