Date: Fri, 10 Jun 2005 12:28:17 +0000 (UTC) From: Brian Feldman <green@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/netinet ip_fw2.c Message-ID: <200506101228.j5ACSHoS049246@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
green 2005-06-10 12:28:17 UTC
FreeBSD src repository
Modified files:
sys/netinet ip_fw2.c
Log:
Modify send_pkt() to return the generated packet and have the caller
do the subsequent ip_output() in IPFW. In ipfw_tick(), the keep-alive
packets must be generated from the data that resides under the
stateful lock, but they must not be sent at that time, as this would
cause a lock order reversal with the normal ordering (interface's
lock, then locks belonging to the pfil hooks).
In practice, this caused deadlocks when using IPFW and if_bridge(4)
together to do stateful transparent filtering.
MFC after: 1 week
Revision Changes Path
1.101 +32 -8 src/sys/netinet/ip_fw2.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200506101228.j5ACSHoS049246>