Date: Mon, 6 Mar 2017 21:50:24 -0800 (PST) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: "Rodney W. Grimes" <rgrimes@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314833 - in head: bin/pkill lib/libxo/tests/encoder libexec/rtld-elf share/termcap usr.bin/chpass usr.bin/passwd usr.sbin/bsdinstall/partedit usr.sbin/mailwrapper usr.sbin/nologin Message-ID: <201703070550.v275oOE5092697@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <21A8D529-BFB9-4774-83FB-5CABD2BC689C@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> > On Mar 6, 2017, at 21:10, Rodney W. Grimes <rgrimes@FreeBSD.org> wrote: > > > > Author: rgrimes > > Date: Tue Mar 7 05:10:38 2017 > > New Revision: 314833 > > URL: https://svnweb.freebsd.org/changeset/base/314833 ... > > > > -SYMLINKS+= ${LIBDIR}/${SHLIB_NAME} /usr/lib/libxo/encoder/test.enc > > +SYMLINKS+= ../../../tests/lib/libxo/${SHLIB_NAME} /usr/lib/libxo/encoder/test.enc > > This change breaks setting TESTSBASE != /usr/tests . Please fix (my employer depends on this being functional). > Thanks, I am just going to revert this until the issue with SYMLINKS vs RSYMLINKS and probably a much better fix in bsd.*.mk can be implemented. I can live with one last nasty wart of an absolute link in DESTDIR until then. The important functional ones are gone now. To fix this without changing SYMLINKS would involve adding a local install: target which would be more mess than having the one absolute link. > -Ngie -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201703070550.v275oOE5092697>