From owner-cvs-all@FreeBSD.ORG Sat Dec 10 02:03:10 2011 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E3DC21065673; Sat, 10 Dec 2011 02:03:10 +0000 (UTC) (envelope-from kubito@gmail.com) Received: from mail-gy0-f182.google.com (mail-gy0-f182.google.com [209.85.160.182]) by mx1.freebsd.org (Postfix) with ESMTP id 77E948FC0C; Sat, 10 Dec 2011 02:03:10 +0000 (UTC) Received: by ghbg20 with SMTP id g20so3697913ghb.13 for ; Fri, 09 Dec 2011 18:03:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=Okz/ql7Zaucuh+KVsGpwbdP+Geixi6C61vPcl6H7RX0=; b=dU+lQFSQL+IaMdbckmfiYQFEluvlqb2MLb3fmP6R+Zf8ulXhQhSs7j0lKGzhK928Ix hrZQ+xhnuB0Uag5EUqAOBOnmxUASghVxNccNonK2JWlEzoZj9u++oqzIgGIIrRC/gVy/ 4iIoIkvehBMrwQOopJJZ0OYJgDa44r0inl1yY= Received: by 10.236.155.36 with SMTP id i24mr15769960yhk.43.1323482589693; Fri, 09 Dec 2011 18:03:09 -0800 (PST) Received: from gibbon.gmail.com ([189.61.210.138]) by mx.google.com with ESMTPS id o50sm18189027yhl.9.2011.12.09.18.03.05 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 09 Dec 2011 18:03:08 -0800 (PST) Sender: Raphael Kubo da Costa From: Raphael Kubo da Costa To: Dmitry Marakasov References: <201111101950.pAAJoQOb072790@repoman.freebsd.org> <20111209005145.GA1551@hades.panopticon> <201112091310.18922.makc@issp.ac.ru> <20111209154940.GA77124@hades.panopticon> Date: Sat, 10 Dec 2011 00:02:55 -0200 In-Reply-To: <20111209154940.GA77124@hades.panopticon> (Dmitry Marakasov's message of "Fri, 9 Dec 2011 19:49:40 +0400") Message-ID: <874nx9gp4g.fsf@FreeBSD.org> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.90 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain Cc: cvs-ports@freebsd.org, Max Brazhnikov , cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/Mk bsd.cmake.mk X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Dec 2011 02:03:11 -0000 Dmitry Marakasov writes: > * Max Brazhnikov (makc@issp.ac.ru) wrote: > >> > > Remove CMAKE_USE_PTHREAD. >> > > >> > > This has been in area51 since April, and discussions with makc >> > > indicate this was only needed when we supported FreeBSD < 7. >> > > >> > > Approved by: avilla (mentor), portmgr (tabthorpe) >> > > Feature safe: yes >> > > >> > > Revision Changes Path >> > > 1.13 +1 -15 ports/Mk/bsd.cmake.mk >> > >> > This has broken at least devel/bullet. This is not feature safe at all. >> >> Can you show the build log? > > http://people.freebsd.org/~amdmi3/bullet_default.log > > with LDFLAGS=-pthread it builds fine: > > http://people.freebsd.org/~amdmi3/bullet_ldflags.log > > Likely that's a correct way to fix it as bullet CMakeLists.txt > doesn't do any attempts to detect/use thread libs, however the > point is that cited commit is not safe and may touch more ports. Well, we did run test builds before committing, so it should have been a safe commit. The commit touched all ports which used the removed setting, I don't see which others it may have touched. As for the build log: what system is that? Can you post a build log with CMAKE_VERBOSE=1 set?