Date: Tue, 6 Oct 2015 14:23:02 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: "Simon J. Gerraty" <sjg@juniper.net> Cc: Warner Losh <imp@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r288911 - head/share/mk Message-ID: <56143BB6.1010700@FreeBSD.org> In-Reply-To: <18968.1444166223@chaos> References: <201510060418.t964Innu071170@repo.freebsd.org> <56140CAD.8080200@FreeBSD.org> <15356.1444161040@chaos> <5614286D.7020904@FreeBSD.org> <18968.1444166223@chaos>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --26olRiEkvPI8vRIH7DSPGNrI2tURh4dHB Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 10/6/2015 2:17 PM, Simon J. Gerraty wrote: > Bryan Drewery <bdrewery@FreeBSD.org> wrote: >>> But wouldn't that imply that /usr/src/share/mk is the right set of >>> makefiles to use for /usr/src/ports/ >>> >>> What would you consider the right sys.mk etc would be in such a case?= >>> >> >> For our case we want the checked in src/share/mk to be used rather tha= n >=20 > Are you refering to a src/share/mk which is sibling to src/ports/* or > something else? >=20 > Because with MAKESYSPATH=3D.../share/mk src/share/mk/sys.mk is what yo= u > should find. Right. That's what I'm referring to and what I prefer. >=20 >> the older /usr/share/mk as it is easier to support. If there's a probl= em >> we fix in our local.sys.env.mk or bsd.port.mk for instance, it will be= >> used by updating the checkout. This was something we backported, >> without the src.conf inclusion in sys.mk, and were running with fine. >=20 > I might be confused... If we update our checked in share/mk/custom.sys.env.mk file, we want all builds to get it before having to install it to /usr/share/mk. We for a period were using a script to wrap make to setup the environment before we realized sys.mk was already capable of doing this. Being able to bind a build to a specific environment is important, vs using the environment installed from the last build or a foreign /usr/share/mk (FreeBSD's files= ). >=20 > It might help to differentiate the question of finding the right sys.mk= > which IMO is critical to a happy outcome, from what to do with src.* if= > present. >=20 > Normally anything under $SRCTOP should be subject to src.* - by > definition. >=20 > But there's no reason you cannot make exceptions - by (as I think you > already mentioned) adding a check for $SRCTOP/ports in local*sys*mk > to suppress src.conf at least. >=20 Yes that has been my local fix for now. Perhaps my fix should get checked in so no one else is surprised by src.conf, and all of the tweaks its options set, coming in. It feels really dirty though. --=20 Regards, Bryan Drewery --26olRiEkvPI8vRIH7DSPGNrI2tURh4dHB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWFDu3AAoJEDXXcbtuRpfPynkH/1iSg/ORAkiBmq6ugaZQGj1T ewz2r/Z4i2oAvFaaE2vvXlk/7ITduEq+TG64oG5lFFiCfGR0uyCeHMkevxEqnJuU SWh3l5399yTcmpQpfZU5RqW86nLvzdWk6dFKIviboMI8hf9bjqPIDIPFh4nZPAgu 50Snq1LbMfiuXVITxQQS753TUD7GGN1pbPFsM6SJHcfvCRYGTfA4oVEtJXhqiRO0 AcY/gEGN6NkXGbj3W5k5u+Cgwugg+riE35oaIHkYfcb4a8vwD/UU/WGw+c803u6p UvMU1tTi+rx5geExHhvSXSPYk46YCJ0xGlDKYyL1u8/GRY4r8oXXUgFlM/WQBEU= =GDIk -----END PGP SIGNATURE----- --26olRiEkvPI8vRIH7DSPGNrI2tURh4dHB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56143BB6.1010700>