From owner-freebsd-fs@freebsd.org Wed Aug 22 07:06:11 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9403D108F3A2; Wed, 22 Aug 2018 07:06:11 +0000 (UTC) (envelope-from outbackdingo@gmail.com) Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 11AAE8609B; Wed, 22 Aug 2018 07:06:11 +0000 (UTC) (envelope-from outbackdingo@gmail.com) Received: by mail-wm0-x243.google.com with SMTP id o18-v6so1102872wmc.0; Wed, 22 Aug 2018 00:06:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Kv9NBQ1OU4NjWKQca39SP/buz3RX95dJPCu8EWhHrK8=; b=F2hC6QsqP7daI3Xh0dw7BLkVlGlcxp4Z7OtoJAViqTOPiUYFPlRRQwX16IcXu9vbZk rwsxKKWWzzSYFRahVBpHxDHWd8KwLMYodF8lZm82ItEqnikMZIhlOzp71YmMfZkMLQj8 ITs24Jx2IPcgRFX13fn39KvdxcAZcGT+k+69tAMvymPjoOeciS/sZ1pQkhTtwPyDYtXq Wq/QnPNhwMIrMkrfUW/yFcdU1WPvYYskxmI3ZlDo1uMk6Tx3uRO1u390G6ExovoWU7JM I86fWM2PoIp/vQMBiTGX3PyE3aUNQCDWmLQmLcK2mXyxYN5s+F6mOfuUfFXRLvMuVpa8 W+tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Kv9NBQ1OU4NjWKQca39SP/buz3RX95dJPCu8EWhHrK8=; b=iNUzeE5872Uz8+TpS52SyaPa6HoevaPTnygYF5K80pO95pX6ultBu00B55RxHvj8X/ YYglSSB9VaRsrRyCUndEdJcFr+Sy5BQUAcqdnBuGpao1NzFMaJ0lZiz+fdimnj/h1DS7 XCfpzqKBHqZGzbyEq+xwSkHGCX4r2WVfAjHt7hBwGBlQ5ookRoGM+EuO37K12AoZsq4m 74Mn+KBSSSIAPmuk1lLkY0j46QTdsId1A3YzqTQpkGJi4Tl9raIf4k4eFVMKX0cFg3pq O+7ebyTXfc9WpI1LCJnX9Xj8eOMSQ82BnOgq+6OQ4WFhyLBWbxKjuWF/bpXBPQ1pT/JB JMNg== X-Gm-Message-State: APzg51C0SN2TZzCXE3sqyfZHM4dErWdNOcrM/qhnDklEgYsjl7pCp97W 5ej7d5cyy6luI1tJKnPYqmLZlsu+es4MduNh8aEqPiRp X-Google-Smtp-Source: ANB0VdawG0q1D8Yq8mOTpmdMRawETmIEsROCcVOaGcO1B1yNdvGHcRUzbxA3WzzThZYYuyOtl2OuT2odSEOzbqlr9rI= X-Received: by 2002:a1c:98a:: with SMTP id 132-v6mr1537862wmj.86.1534921569731; Wed, 22 Aug 2018 00:06:09 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Outback Dingo Date: Wed, 22 Aug 2018 09:05:33 +0200 Message-ID: Subject: Re: Native Encryption for ZFS on FreeBSD CFT To: mmacy@freebsd.org Cc: freebsd-current@freebsd.org, freebsd-fs@freebsd.org, sef@ixsystems.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2018 07:06:11 -0000 of course interesting work, but unfortunately, and as you know me, what would i say next cc -target x86_64-unknown-freebsd12.0 --sysroot=/usr/obj/usr/src/amd64.amd64/tmp -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin -O2 -pipe -I/usr/src/sys/cddl/compat/opensolaris -I/usr/src/cddl/compat/opensolaris/include -I/usr/src/cddl/compat/opensolaris/lib/libumem -I/usr/src/cddl/contrib/opensolaris/lib/libzpool/common -I/usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs -I/usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua -I/usr/src/sys/cddl/contrib/opensolaris/common/zfs -I/usr/src/sys/cddl/contrib/opensolaris/uts/common -I/usr/src/cddl/contrib/opensolaris/head -I/usr/src/cddl/contrib/opensolaris/lib/libnvpair -I/usr/src/cddl/contrib/opensolaris/lib/libcmdutils -DWANTS_MUTEX_OWNED -I/usr/src/lib/libpthread/thread -I/usr/src/lib/libpthread/sys -I/usr/src/lib/libthr/arch/amd64/include -g -DDEBUG=1 -DZFS_DEBUG=1 -DNEED_SOLARIS_BOOLEAN -g -MD -MF.depend.freebsd_crypto.o -MTfreebsd_crypto.o -std=iso9899:1999 -fstack-protector-strong -Wno-pointer-sign -Wno-unknown-pragmas -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unused-local-typedef -Wno-address-of-packed-member -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -Wno-parentheses -Qunused-arguments -c /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/freebsd_crypto.c -o freebsd_crypto.o /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/freebsd_crypto.c:62:19: warning: tentative definition of variable with internal linkage has incomplete non-array type 'struct mtx' [-Wtentative-definition-incomplete-type] static struct mtx freebsd_crypto_mutex; ^ /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/freebsd_crypto.c:62:15: note: forward declaration of 'struct mtx' static struct mtx freebsd_crypto_mutex; ^ /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/freebsd_crypto.c:63:35: error: expected identifier MTX_SYSINIT(freebsd_crypto_mutex, &freebsd_crypto_mutex, "FreeBSD ZFS Crypto mutex", MTX_DEF); ^ /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/freebsd_crypto.c:63:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int] MTX_SYSINIT(freebsd_crypto_mutex, &freebsd_crypto_mutex, "FreeBSD ZFS Crypto mutex", MTX_DEF); ^ /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/freebsd_crypto.c:62:19: error: tentative definition has type 'struct mtx' that is never completed static struct mtx freebsd_crypto_mutex; ^ /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/freebsd_crypto.c:62:15: note: forward declaration of 'struct mtx' static struct mtx freebsd_crypto_mutex; ^ 2 warnings and 2 errors generated. *** Error code 1 On Wed, Aug 22, 2018 at 4:28 AM Matthew Macy wrote: > > On Tue, Aug 21, 2018 at 6:55 PM Matthew Macy wrote: > > > To anyone with an interest in native encryption in ZFS please test the > > projects/zfs-crypto-merge-0820 branch in my freebsd repo: > > https://github.com/mattmacy/networking.git > > > > > Oh and I neglected to state that this work is being supported by iX Systems > and the tree is all built on work done by Sean Fagan at iX Systems. Please > keep him in the loop on any problems encountered. > Thanks. > > > > > ( git clone https://github.com/mattmacy/networking.git -b > > projects/zfs-crypto-merge-0820 ) > > > > The UI is quite close to the Oracle Solaris ZFS crypto with minor > > differences for specifying key location. > > > > Please note that once a feature is enabled on a pool it can't be > > disabled. This means that if you enable encryption support on a pool > > you will never be able to import it in to a ZFS without encryption > > support. For this reason I would strongly advise against using this on > > any pool that can't be easily replaced until this change has made its > > way in to HEAD after the freeze has been lifted. > > > > > > By way of background the original ZoL commit can be found at: > > > > https://github.com/zfsonlinux/zfs/pull/5769/commits/5aef9bedc801830264428c64cd2242d1b786fd49 > > > > Thanks in advance. > > -M > > > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"