From owner-freebsd-wireless@FreeBSD.ORG Mon Apr 21 16:30:48 2014 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 68B9C790 for ; Mon, 21 Apr 2014 16:30:48 +0000 (UTC) Received: from mail-qc0-x235.google.com (mail-qc0-x235.google.com [IPv6:2607:f8b0:400d:c01::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 28F0E1963 for ; Mon, 21 Apr 2014 16:30:48 +0000 (UTC) Received: by mail-qc0-f181.google.com with SMTP id x3so4238269qcv.12 for ; Mon, 21 Apr 2014 09:30:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=j5SY4zH4hwag/6PEwUknBq0W4GsEeBd8vhKBZ+07pRI=; b=sNj0LQTg05uFcC20wf0j4BN4vdFGxCy72EFtIJg+IcYRYWD0CZspnLVzMtqygsz6aF 9d3JlWfuS8R1fjUjilbCJzaj0QQtFSOFugGfCE/lLtQ3zHzXc98AbXlYgpYcJPGLcjIh sc3iuhp+GYbyUW8/6JqLnsKfCKhS3DTRiOYI9yBRHTdhUX29iMteOnVUkqu4d2DC7W1R t6AMDvfeq+yKnSqQfskmzvG0kmy9LffF+yQY1IJemPgeXS7ftPE7iBI4k2imcRgwjn3y kcT1RX4nsXp4RcxPHWBJhT/v5i+7bhLdU6w29n9mLFcDMm0qmbkpf/ZFIX9zTpoqRFhA OBfQ== MIME-Version: 1.0 X-Received: by 10.224.76.74 with SMTP id b10mr43291837qak.49.1398097847332; Mon, 21 Apr 2014 09:30:47 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.224.191.201 with HTTP; Mon, 21 Apr 2014 09:30:47 -0700 (PDT) In-Reply-To: <20140421155853.GD1602@mail0.byshenk.net> References: <201404210205.s3L25p9U064240@svn.freebsd.org> <20140421155853.GD1602@mail0.byshenk.net> Date: Mon, 21 Apr 2014 09:30:47 -0700 X-Google-Sender-Auth: KIrEGnwT92QzzH78nujV8CSmNjE Message-ID: Subject: Re: svn commit: r264710 - head/sys/dev/ath From: Adrian Chadd To: Greg Byshenk , "freebsd-wireless@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Apr 2014 16:30:48 -0000 Hi, Which NIC? -a On 21 April 2014 08:58, Greg Byshenk wrote: > On Sun, Apr 20, 2014 at 07:09:33PM -0700, Adrian Chadd wrote: >> I didn't say it in the commit message, but this should be MFCed to stable/10 . > > > Adrian- > > I'm curious as to what this addresses. > > I attempted to move a router/access point to FreeBSD 10 over the > weekend, and had to revert back to 9 as it was a terrible failure. > > It would invariably spew out masses of 'stuck beacon; resetting' > errors, and then at some point (not obviuously correlated with > those errors) lock up (hard, requiring a hard reset). > > If it is something that the patch might address, then I'll watch > for an MFC to stable/10 > > Thanks, > -greg > > >> On 20 April 2014 19:05, Adrian Chadd wrote: >> > Author: adrian >> > Date: Mon Apr 21 02:05:51 2014 >> > New Revision: 264710 >> > URL: http://svnweb.freebsd.org/changeset/base/264710 >> > >> > Log: >> > Make sure bf_next is NULL'ed out when we're completing up an aggregate >> > frame through the cleanup path. >> > >> > Whilst here, fix the indenting for something I messed up. >> > >> > Tested: >> > >> > * AR5416, STA mode >> > >> > Modified: >> > head/sys/dev/ath/if_ath_tx.c >> > >> > Modified: head/sys/dev/ath/if_ath_tx.c >> > ============================================================================== >> > --- head/sys/dev/ath/if_ath_tx.c Mon Apr 21 02:04:37 2014 (r264709) >> > +++ head/sys/dev/ath/if_ath_tx.c Mon Apr 21 02:05:51 2014 (r264710) >> > @@ -4600,10 +4600,11 @@ ath_tx_comp_cleanup_aggr(struct ath_soft >> > >> > ATH_TX_UNLOCK(sc); >> > >> > - /* Handle frame completion */ >> > + /* Handle frame completion as individual frames */ >> > bf = bf_first; >> > while (bf) { >> > bf_next = bf->bf_next; >> > + bf->bf_next = NULL; >> > ath_tx_default_comp(sc, bf, 1); >> > bf = bf_next; >> > } >> > @@ -5849,7 +5850,7 @@ ath_tx_node_reassoc(struct ath_softc *sc >> > ":", >> > i); >> > /* >> > - * In case there's a followup call to this, only call it >> > + * In case there's a followup call to this, only call it >> > * if we don't have a cleanup in progress. >> > */ >> > if (! tid->cleanup_inprogress) { >> > >> _______________________________________________ >> svn-src-all@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/svn-src-all >> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" > > -- > greg byshenk - gbyshenk@byshenk.net - Portland, OR USA