Date: Tue, 23 Sep 2014 21:44:34 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r272032 - head/sys/conf Message-ID: <20140923184434.GG8870@kib.kiev.ua> In-Reply-To: <5421BC8E.6000709@FreeBSD.org> References: <201409231704.s8NH4Lcv098184@svn.freebsd.org> <20140923182051.GF8870@kib.kiev.ua> <5421BC8E.6000709@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Sep 23, 2014 at 01:31:42PM -0500, Bryan Drewery wrote: > On 9/23/2014 1:20 PM, Konstantin Belousov wrote: > > On Tue, Sep 23, 2014 at 05:04:21PM +0000, Bryan Drewery wrote: > >> Author: bdrewery > >> Date: Tue Sep 23 17:04:21 2014 > >> New Revision: 272032 > >> URL: http://svnweb.freebsd.org/changeset/base/272032 > >> > >> Log: > >> DEBUG_LOCKS no longer modifies 'struct vnode', nor does fstat(1) use it. > >> fstat(1) now uses libprocstat(9). There is no userland impact to using this. > > > > DEBUG_VFS_LOCKS does modify KBI of VFS, by adding struct stack to > > lockmgr, and lockmgr is embedded into each struct vnode. > > > > VFS modules, in particular, filesystems, compiled for mismatched > > kernel WRT DEBUG_VFS_LOCKS, would cause strange breakage. > > Well, perhaps the comment needs to be updated to state that > DEBUG_VFS_LOCKS modifies VFS KBI so any VFS modules will need to recompiled. > > I did see the stack was moved to lockmgr, but given the use of > libprocstat, and lockmgr being a kernel struct, I don't think it's worth > mentioning userland here. > > Sound good? I agree, I do not think that userland is affected.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140923184434.GG8870>