From owner-cvs-all@FreeBSD.ORG Mon Aug 23 21:39:29 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 74FCD16A4CE; Mon, 23 Aug 2004 21:39:29 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6A90A43D53; Mon, 23 Aug 2004 21:39:29 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i7NLdT6Q094669; Mon, 23 Aug 2004 21:39:29 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i7NLdToC094668; Mon, 23 Aug 2004 21:39:29 GMT (envelope-from peter) Message-Id: <200408232139.i7NLdToC094668@repoman.freebsd.org> From: Peter Wemm Date: Mon, 23 Aug 2004 21:39:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/amd64 mp_machdep.c pmap.c src/sys/i386/i386 mp_machdep.c pmap.c src/sys/kern subr_smp.c src/sys/sys smp.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Aug 2004 21:39:29 -0000 peter 2004-08-23 21:39:29 UTC FreeBSD src repository Modified files: sys/amd64/amd64 mp_machdep.c pmap.c sys/i386/i386 mp_machdep.c pmap.c sys/kern subr_smp.c sys/sys smp.h Log: Commit Doug White and Alan Cox's fix for the cross-ipi smp deadlock. We were obtaining different spin mutexes (which disable interrupts after aquisition) and spin waiting for delivery. For example, KSE processes do LDT operations which use smp_rendezvous, while other parts of the system are doing things like tlb shootdowns with a different mutex. This patch uses the common smp_rendezvous mutex for all MD home-grown IPIs that spinwait for delivery. Having the single mutex means that the spinloop to aquire it will enable interrupts periodically, thus avoiding the cross-ipi deadlock. Obtained from: dwhite, alc Reviewed by: jhb Revision Changes Path 1.243 +2 -5 src/sys/amd64/amd64/mp_machdep.c 1.492 +6 -6 src/sys/amd64/amd64/pmap.c 1.236 +2 -4 src/sys/i386/i386/mp_machdep.c 1.495 +8 -8 src/sys/i386/i386/pmap.c 1.189 +8 -1 src/sys/kern/subr_smp.c 1.78 +1 -0 src/sys/sys/smp.h