Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 24 Sep 2021 01:35:23 GMT
From:      Kevin Bowling <kbowling@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: a026f3294083 - stable/13 - e1000: fix timeout for shadow RAM write
Message-ID:  <202109240135.18O1ZN91029491@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by kbowling (ports committer):

URL: https://cgit.FreeBSD.org/src/commit/?id=a026f3294083b585bef81c8a01253fdbae50e72a

commit a026f3294083b585bef81c8a01253fdbae50e72a
Author:     Chengwen Feng <fengchengwen@huawei.com>
AuthorDate: 2021-04-21 09:15:35 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2021-09-24 01:31:53 +0000

    e1000: fix timeout for shadow RAM write
    
    This fixes the timed out for shadow RAM write EEWR can't be detected.
    
    Fixes: 5a32a257f957 ("e1000: more NICs in base driver")
    Cc: stable@dpdk.org
    
    Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
    Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
    Acked-by: Haiyue Wang <haiyue.wang@intel.com>
    
    Approved by:    imp
    Obtained from:  DPDK (4a8ab48ec47b3616272e50620b8e1a9599358ea6)
    MFC after:      1 week
    
    (cherry picked from commit f6517a7e69c10c6057d6c990a9f3ea22a2b62398)
---
 sys/dev/e1000/e1000_i210.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sys/dev/e1000/e1000_i210.c b/sys/dev/e1000/e1000_i210.c
index cd85a8c3172a..d3692db11245 100644
--- a/sys/dev/e1000/e1000_i210.c
+++ b/sys/dev/e1000/e1000_i210.c
@@ -195,6 +195,8 @@ static s32 e1000_write_nvm_srwr(struct e1000_hw *hw, u16 offset, u16 words,
 	}
 
 	for (i = 0; i < words; i++) {
+		ret_val = -E1000_ERR_NVM;
+
 		eewr = ((offset + i) << E1000_NVM_RW_ADDR_SHIFT) |
 			(data[i] << E1000_NVM_RW_REG_DATA) |
 			E1000_NVM_RW_REG_START;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202109240135.18O1ZN91029491>