Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 15 Oct 2002 14:35:01 -0700 (PDT)
From:      Poul-Henning Kamp <phk@FreeBSD.org>
To:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   cvs commit: src/sys/dev/kbd atkbdcreg.h
Message-ID:  <200210152135.g9FLZ193010617@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
phk         2002/10/15 14:35:01 PDT

  Modified files:
    sys/dev/kbd          atkbdcreg.h 
  Log:
  Include "opt_kbd.h" since certain structures size depend on the value
  of KBDIO_DEBUG which may be defined in the kernel config (as it is in NOTES).
  
  This kind of bug is a _really_ horribly thing as we end up with one bit
  of code thinking a particular structure is 136 bytes and another that it
  is only 112 bytes.
  
  Ideally all places would remember to #include the right "opt_foo.h" file,
  but I think in practice file containing the variable sized struct should
  #include it explicitly as a precaution.
  
  Detected by:    FlexeLint
  
  Revision  Changes    Path
  1.9       +3 -1      src/sys/dev/kbd/atkbdcreg.h

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200210152135.g9FLZ193010617>