From owner-cvs-all Tue Oct 15 14:35: 3 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6124537B401; Tue, 15 Oct 2002 14:35:02 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 865BD43EAC; Tue, 15 Oct 2002 14:35:01 -0700 (PDT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id g9FLZ1Mt010618; Tue, 15 Oct 2002 14:35:01 -0700 (PDT) (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.6/8.12.3/Submit) id g9FLZ193010617; Tue, 15 Oct 2002 14:35:01 -0700 (PDT) Message-Id: <200210152135.g9FLZ193010617@repoman.freebsd.org> From: Poul-Henning Kamp Date: Tue, 15 Oct 2002 14:35:01 -0700 (PDT) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/kbd atkbdcreg.h X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG phk 2002/10/15 14:35:01 PDT Modified files: sys/dev/kbd atkbdcreg.h Log: Include "opt_kbd.h" since certain structures size depend on the value of KBDIO_DEBUG which may be defined in the kernel config (as it is in NOTES). This kind of bug is a _really_ horribly thing as we end up with one bit of code thinking a particular structure is 136 bytes and another that it is only 112 bytes. Ideally all places would remember to #include the right "opt_foo.h" file, but I think in practice file containing the variable sized struct should #include it explicitly as a precaution. Detected by: FlexeLint Revision Changes Path 1.9 +3 -1 src/sys/dev/kbd/atkbdcreg.h To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message