Date: Fri, 1 Feb 2002 16:20:58 +0000 From: David Taylor <davidt@yadt.co.uk> To: Sheldon Hearn <sheldonh@starjuice.net> Cc: freebsd-bugs@FreeBSD.org Subject: Re: bin/34497: calendar(1) does not understand calendars Message-ID: <20020201162058.GA46152@gattaca.yadt.co.uk> In-Reply-To: <95810.1012562475@axl.seasidesoftware.co.za> References: <200201312130.g0VLU2d96837@freefall.freebsd.org> <95810.1012562475@axl.seasidesoftware.co.za>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 01 Feb 2002, Sheldon Hearn wrote: > > > On Thu, 31 Jan 2002 13:30:02 PST, David Taylor wrote: > > > I was going to submit a patch for that along with a fix for the original > > problem, until I decided there was no way I was fixing the original > > problem. > > Can you check out the NetBSD and OpenBSD repos and see whether they have > a solution? Often, we can just borrow code from those projects, where > some problems get fixed long before they're even noticed in FreeBSD. OpenBSD does appear to have a fix for that problem (almost identical to my fix, in fact). There are a lot of changes (including addition of various comments explaining some of the weirder things the code is doing, which is nice) which would probably be useful. They've also changed the way -A/-B is handled internally (-B 3 and -A 2 is converted to -A 5, but the time is moved back 3 days), which helps simplify everything a lot. I've no idea if it comes close to fixing all the bugs, however. NetBSD didn't merge the change (from FreeBSD, apparantly) which split calendar.c into calendar.c/day.c/io.c, etc, but have commmited some cleanups (which introduced a minor memory leak: blank lines are never freed -- any idea where to report that?). They don't _seem_ to have fixed -- David Taylor davidt@yadt.co.uk "The future just ain't what it used to be" To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020201162058.GA46152>