From owner-freebsd-arch@FreeBSD.ORG Tue May 12 16:59:51 2009 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 69DD8106566B for ; Tue, 12 May 2009 16:59:51 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:7b8:613:100::211]) by mx1.freebsd.org (Postfix) with ESMTP id 099978FC0C for ; Tue, 12 May 2009 16:59:50 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: by palm.hoeg.nl (Postfix, from userid 1000) id ED4521D04A; Tue, 12 May 2009 18:59:49 +0200 (CEST) Date: Tue, 12 May 2009 18:59:49 +0200 From: Ed Schouten To: Jeff Roberson Message-ID: <20090512165949.GF58540@hoeg.nl> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GCRJOSQGwEYxR+j1" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Cc: arch@freebsd.org Subject: Re: lockless file descriptor lookup X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 May 2009 16:59:51 -0000 --GCRJOSQGwEYxR+j1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Jeff, * Jeff Roberson wrote: > Once the file descriptor is resolved, we verify the path via the =20 > descriptor table once more to ensure that it has not changed. At this = =20 > point, we have a valid reference or we drop an invalid reference and =20 > retry. It's nice to see someone stepped up to implement this. Just out of curiosity, have you done any benchmarks to see how many percent of the time a thread needs more than one attempt to obtain a valid reference on a common workload? Maybe it would be nice for diagnostic purposes to add two sysctls to obtain the amount of successful and unsuccessful attempts. --=20 Ed Schouten WWW: http://80386.nl/ --GCRJOSQGwEYxR+j1 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkoJqwUACgkQ52SDGA2eCwWFFgCfX+ZV7n/CbAGIx9OhQSQNqE73 KnYAniCy0fesWrS7ByA/efWM/gKrF3nT =WnZE -----END PGP SIGNATURE----- --GCRJOSQGwEYxR+j1--