Date: Wed, 16 Jul 2003 00:43:37 -0700 From: Marcel Moolenaar <marcel@xcllnt.net> To: Kris Kennaway <kris@obsecurity.org> Cc: current@FreeBSD.org Subject: Fix for rman [was: Re: [-CURRENT tinderbox] ...] Message-ID: <20030716074337.GA17997@dhcp01.pn.xcllnt.net> In-Reply-To: <20030716051601.GA25527@rot13.obsecurity.org> References: <200307141153.h6EBrJKk045346@cueball.rtp.FreeBSD.org> <20030715175821.K34004@beagle.fokus.fraunhofer.de> <xzp65m3vfw1.fsf@dwp.des.no> <20030715185438.GB15674@dhcp01.pn.xcllnt.net> <xzpy8yzty2m.fsf@dwp.des.no> <20030715190456.GC15674@dhcp01.pn.xcllnt.net> <20030715193518.GA1660@crow.dom2ip.de> <20030716010908.GA24218@rot13.obsecurity.org> <20030716051103.GB17596@dhcp01.pn.xcllnt.net> <20030716051601.GA25527@rot13.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--BOKacYhQ+x31HxR3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 15, 2003 at 10:16:01PM -0700, Kris Kennaway wrote: > > > > malloc, you say? I have build failures in XFree4-clients because > > rman coredumps and I have a backtrace full of free() frames... > > > > Coincidence? > > Some of the XFree86 utilities contain malloc bugs..rman in particular > has been dumping core on certain ports for a couple of years. I tried > to track it down once but couldn't find it. [cc anholt@] The attached patch fixes rman. The faulting case is "\\\0". The '\0' was handled in the default case for escaped characters, which also incremented the pointer p beyond the terminating '\0'. Oh: this goes to devel/imake-4 of course. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net --BOKacYhQ+x31HxR3 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="patch-rman.c" --- ../extras/rman/rman.c.orig Tue Jul 15 23:53:53 2003 +++ ../extras/rman/rman.c Tue Jul 15 23:44:21 2003 @@ -4104,6 +4104,9 @@ } } break; + case 0: + /* ignore */ + break; default: /* unknown escaped character */ sputchar(*p++); } --BOKacYhQ+x31HxR3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030716074337.GA17997>