Date: Mon, 18 Nov 2002 06:46:03 +0800 From: Clive Lin <clive@freebsd.org> To: Jake Burkholder <jake@locore.ca> Cc: Julian Elischer <julian@elischer.org>, current@freebsd.org, sparc64@freebsd.org Subject: Re: sparc64 tinderbox failure Message-ID: <20021117224603.GA10020@fatpipi.cirx.org> In-Reply-To: <20021117154655.B2737@locore.ca> References: <200211172019.gAHKJCRT073699@bowie.private> <Pine.BSF.4.21.0211171222320.53326-100000@InterJet.elischer.org> <20021117154655.B2737@locore.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Nov 17, 2002 at 03:46:55PM -0500, Jake Burkholder wrote: > Apparently, On Sun, Nov 17, 2002 at 12:23:20PM -0800, > Julian Elischer said words to the effect of; > > On Sun, 17 Nov 2002, Mike Barcroft wrote: > > > -------------------------------------------------------------- > > > >>> Kernel build for GENERIC started on Sun Nov 17 20:01:33 GMT 2002 > > > -------------------------------------------------------------- > > > ===> ipfilter > > > /tinderbox/sparc64/src/sys/kern/kern_thread.c: In function `kse_create': > > > /tinderbox/sparc64/src/sys/kern/kern_thread.c:498: `mp_ncpus' undeclared (first use in this function) > > > /tinderbox/sparc64/src/sys/kern/kern_thread.c:498: (Each undeclared identifier is reported only once > > > /tinderbox/sparc64/src/sys/kern/kern_thread.c:498: for each function it appears in.) > > > > > > ok mea culpa.. > > > > what is there in SPARC that should be used instead..? > > mp_ncpus is defined in sys/smp.h which is not included kern_thread.c > I don't see why this builds on any platform. > > Jake This does not compile on i386 with options SMP, either. It looks like a '#if 0' was removed in kern_thread.c rev 1.61, which exposes bug in SMP case. Something like this should fix kernel building. (I have no idea where to place the #include, though) Index: kern_thread.c =================================================================== RCS file: /home/ncvs/src/sys/kern/kern_thread.c,v retrieving revision 1.61 diff -u -r1.61 kern_thread.c --- kern_thread.c 17 Nov 2002 11:47:03 -0000 1.61 +++ kern_thread.c 17 Nov 2002 22:22:35 -0000 @@ -47,6 +47,10 @@ #include <sys/ktr.h> #include <sys/ucontext.h> +#ifdef SMP +#include <sys/smp.h> +#endif + #include <vm/vm.h> #include <vm/vm_object.h> #include <vm/pmap.h> To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021117224603.GA10020>