From owner-cvs-all@FreeBSD.ORG Fri Nov 21 22:00:50 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 48DF11065679; Fri, 21 Nov 2008 22:00:50 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id DEE558FC19; Fri, 21 Nov 2008 22:00:49 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.3/8.14.3) with ESMTP id mALM0hcR083081; Fri, 21 Nov 2008 17:00:43 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: David Xu Date: Fri, 21 Nov 2008 17:00:10 -0500 User-Agent: KMail/1.9.7 References: <200510300212.j9U2CnWl089007@repoman.freebsd.org> In-Reply-To: <200510300212.j9U2CnWl089007@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200811211700.11204.jhb@freebsd.org> Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Fri, 21 Nov 2008 17:00:43 -0500 (EST) X-Virus-Scanned: ClamAV 0.93.1/8661/Fri Nov 21 10:39:30 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys aio.h signal.h signalvar.h src/sys/kern syscalls.master vfs_aio.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Nov 2008 22:00:50 -0000 On Saturday 29 October 2005 10:12:49 pm David Xu wrote: > davidxu 2005-10-30 02:12:49 UTC > > FreeBSD src repository > > Modified files: > sys/sys signal.h signalvar.h aio.h > sys/kern syscalls.master vfs_aio.c > Log: > Fix sigevent's POSIX incompatible problem by adding member fields > sigev_notify_function and sigev_notify_attributes. AIO syscalls > use sigevent, so they have to be adjusted. > > Reviewed by: alc I'm looking at doing 32-bit compat for AIO, and the __spare__ thing in 'struct aiocb' strikes me as rather odd. For one, why not use 'struct osigevent __spare__;' instead of the explicit sizeof()'s? The sizeof's make assumptions about padding for example. Secondly, since you bumped the syscalls for the new structure, you didn't need the __spare__ hack at all. -- John Baldwin