Date: Tue, 2 Dec 2003 16:05:30 -0500 From: Mathew Kanner <mat@cnd.mcgill.ca> To: Maxime Henrion <mux@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: 5.2-BETA dsp.c duplicate lock Message-ID: <20031202210530.GG54011@cnd.mcgill.ca> In-Reply-To: <20031202203330.GF54011@cnd.mcgill.ca> References: <bq68t8$c8n$2@sea.gmane.org> <bqfgsc$qmu$1@sea.gmane.org> <20031201142022.GK8404@elvis.mu.org> <20031201193837.GD49341@cnd.mcgill.ca> <20031201230259.GL8404@elvis.mu.org> <20031202203330.GF54011@cnd.mcgill.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
On Dec 02, Mathew Kanner wrote: > On Dec 01, Maxime Henrion wrote: > [snip] > I believe that your patch should fix the problem. In general > I see one of three strategies, > > 1) Your patch, > 2) create a new snd_mtxcreate_chan for channels that sets the > flags DUP_OK. > 3) Fix locking to never hold duplicates. First glance suggests > that would be contained in dsp.c, the ioctl handler is the real > problem and seems inconsistent with itself in regards to locking. > Ugh. Why do the best ideas happen after you send? 4) Make read and write channel locks of a different class. --Mat -- In general, a standard is very useful, whether it's de facto or du jour. - Microsoft's Greg Sullivan as misquoted by News.Com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031202210530.GG54011>