Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 12 Feb 2010 15:34:26 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        "Philip M. Gollucci" <pgollucci@p6m7g8.com>
Cc:        cvs-ports@FreeBSD.org, Doug Barton <dougb@FreeBSD.org>, cvs-all@FreeBSD.org, Dmitry Marakasov <amdmi3@amdmi3.ru>, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/audio Makefile ports/audio/deadbeef Makefile distinfo pkg-descr pkg-plist ports/audio/deadbeef/files patch-Makefile.am patch-Makefile.in patch-configure patch-configure.ac
Message-ID:  <20100212153426.GA82271@FreeBSD.org>
In-Reply-To: <4B749FFB.80506@p6m7g8.com>
References:  <201002092323.o19NNRvB090976@repoman.freebsd.org> <20100210092407.GA30717@FreeBSD.org> <20100210125022.GD1538@hades.panopticon> <4B749F6E.5020806@FreeBSD.org> <4B749FFB.80506@p6m7g8.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 11, 2010 at 07:25:31PM -0500, Philip M. Gollucci wrote:
> ... that we *try* to always patch the .am/.ac files and use
> USE_AUTOTOOLS to re-generate the .in files.

Only if resulting .in patch is overly complicated and/or large, which
occasionally happens with auto-generated contents.  In this case,
if patching original (e.g. .am) can result in smaller diff, it is
preferred over .in patching (doing it also makes the port to require
USE_AUTOTOOLS, quite naturally).  If simple .in patch is enough, there
is no much point to force our users to pull shitware (which autotools is
perfect example of) just to build the port.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100212153426.GA82271>