Date: Fri, 21 Feb 1997 00:47:02 +1100 From: Bruce Evans <bde@zeta.org.au> To: ache@nagual.ru, bde@freefall.freebsd.org Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/kern sys_generic.c Message-ID: <199702201347.AAA02079@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>Thanks, but I see no commit for removing p_selbits_size and p_selbits >fields from struct proc... kern_exit.c also does free for p_selbits and >needs fixing after remove. I'll leave them until it is decided that the caching scheme is unnecssary. >BTW, do we really need free() of malloc storage before return? If program >use huge select once, in most practical cases it will mean that the same >select code will be executed again, i.e. the same hudge select will be >malloced/freeed. Maybe return to old p_selbits caching scheme? Maybe, but I think there are more important things to cache, starting with the 1K namei buffer. Most processes don't do many lookups, but things like `find / -xdev -type f' do a lot (about 4 per file). I think this isn't worth optimizing either :-). Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199702201347.AAA02079>