From owner-freebsd-ports@FreeBSD.ORG  Tue Nov 30 09:33:39 2010
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B5040106566B
	for <ports@FreeBSD.org>; Tue, 30 Nov 2010 09:33:39 +0000 (UTC)
	(envelope-from ade@FreeBSD.org)
Received: from panix.lovett.com (panix.lovett.com [166.84.7.128])
	by mx1.freebsd.org (Postfix) with ESMTP id 8F8288FC14
	for <ports@FreeBSD.org>; Tue, 30 Nov 2010 09:33:39 +0000 (UTC)
Received: from cpe-66-68-128-204.austin.res.rr.com ([66.68.128.204]
	helo=[172.16.32.150])
	by panix.lovett.com with esmtpsa (TLSv1:AES128-SHA:128)
	(Exim 4.72 (FreeBSD)) (envelope-from <ade@FreeBSD.org>)
	id 1PNMag-000Pe1-Fu; Tue, 30 Nov 2010 09:33:38 +0000
Mime-Version: 1.0 (Apple Message framework v1082)
Content-Type: text/plain; charset=us-ascii
From: Ade Lovett <ade@FreeBSD.org>
In-Reply-To: <20101130041323.GA17404@lonesome.com>
Date: Tue, 30 Nov 2010 03:33:27 -0600
Content-Transfer-Encoding: quoted-printable
Message-Id: <5A25461F-A28C-415C-A8AB-59C91E1B1CC7@FreeBSD.org>
References: <20101130041323.GA17404@lonesome.com>
To: Mark Linimon <linimon@lonesome.com>
X-Mailer: Apple Mail (2.1082)
Cc: FreeBSD Ports <ports@FreeBSD.org>
Subject: Re: CFR: patch to cleanup usage of SRC_BASE in various ports
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Nov 2010 09:33:39 -0000


On Nov 29, 2010, at 22:13 , Mark Linimon wrote:
> I would appreciate feedback on the following patch:
>=20
>  http://people.freebsd.org/~linimon/patches/diff.out.srcbase

Seems like there's an awful lot of duplication of:

SRC_BASE?=3D /usr/src

in those port Makefiles.

What's wrong with adding the above, with a bit of documentation, to =
bsd.port.mk ?

This also allows portlint to be trivially extended to warn/fatal on =
seeing /usr/src in any port Makefile, pointing the author in the =
direction of ${SRC_BASE}

-aDe