From owner-freebsd-hackers@FreeBSD.ORG Fri Jan 20 23:35:37 2012 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4BCF8106564A; Fri, 20 Jan 2012 23:35:37 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) by mx1.freebsd.org (Postfix) with ESMTP id 29AF28FC12; Fri, 20 Jan 2012 23:35:37 +0000 (UTC) Received: from delta.delphij.net (c-76-102-50-245.hsd1.ca.comcast.net [76.102.50.245]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by anubis.delphij.net (Postfix) with ESMTPSA id 87BF6C36E; Fri, 20 Jan 2012 15:35:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=delphij.net; s=anubis; t=1327102537; bh=PRIUIE8W/TFoNRc/qSoWT10GSbqilThafHY5uNKuyn4=; h=Message-ID:Date:From:Reply-To:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=24V20NE5m5k8P1TLVMwo8uRbra7mZE0IRFNt5JLrdWFq4z6wBM8+w9SZnPbACgY6M p5CpTOCzl+2H9up8rOjn9RX9RSrfu9ihs02fCx20dMrEHWukvCemV9MxLUCd/B6+xG wgikBlaONa4DJ7tJH67nf+wZHsZRgCbFQW6Y+LzQ= Message-ID: <4F19FA47.7060908@delphij.net> Date: Fri, 20 Jan 2012 15:35:35 -0800 From: Xin Li Organization: The FreeBSD Project MIME-Version: 1.0 To: Eitan Adler References: <20120112100840.GV31224@deviant.kiev.zoral.com.ua> In-Reply-To: X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Kostik Belousov , jilles@freebsd.org, d@delphij.net, Colin Percival , FreeBSD Hackers Subject: Re: dup3 syscall - atomic set O_CLOEXEC with dup2 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2012 23:35:37 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Eitan, On 01/20/12 15:25, Eitan Adler wrote: > I figure this isn't wanted? Since this is modeled after Linux's dup3() system call, would you please also add a compat entry for it? By the way: > On Thu, Jan 12, 2012 at 10:07 PM, Eitan Adler > wrote: >> Okay - here is version 2 (compile and run tested) Index: >> sys/kern/syscalls.master >> =================================================================== >> >> - --- sys/kern/syscalls.master (revision 229830) >> +++ sys/kern/syscalls.master (working copy) @@ -951,5 +951,6 >> @@ off_t offset, off_t len); } 531 AUE_NULL STD { >> int posix_fadvise(int fd, off_t offset, \ off_t len, int advice); >> } +532 AUE_NULL STD { int dup3(u_int from, u_int >> to, int flags); } I think we want audit here? >> ; Please copy any additions and changes to the following >> compatability tables: ; sys/compat/freebsd32/syscalls.master >> Index: sys/compat/freebsd32/syscalls.master >> =================================================================== >> >> - --- sys/compat/freebsd32/syscalls.master (revision 229830) >> +++ sys/compat/freebsd32/syscalls.master (working copy) @@ >> -997,3 +997,4 @@ uint32_t offset1, uint32_t offset2,\ uint32_t >> len1, uint32_t len2, \ int advice); } +532 AUE_NULL STD >> { int dup3(u_int from, u_int to, int flags); } Ditto... Cheers, - -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk8Z+kYACgkQOfuToMruuMBe/ACfQ9aR5OfPZTS3q/AVNheUDliQ nIYAnjp/5qblxlOLDAvB6AferlpFQjOa =lTV+ -----END PGP SIGNATURE-----